Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 101413006: Implement in-heap backing store for typed arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: GC fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3403 matching lines...) Expand 10 before | Expand all | Expand 10 after
3414 elements_kind)) { 3414 elements_kind)) {
3415 __ SmiUntag(ToRegister(key)); 3415 __ SmiUntag(ToRegister(key));
3416 } 3416 }
3417 Operand operand(BuildFastArrayOperand( 3417 Operand operand(BuildFastArrayOperand(
3418 instr->elements(), 3418 instr->elements(),
3419 key, 3419 key,
3420 instr->hydrogen()->key()->representation(), 3420 instr->hydrogen()->key()->representation(),
3421 elements_kind, 3421 elements_kind,
3422 0, 3422 0,
3423 instr->additional_index())); 3423 instr->additional_index()));
3424 if (elements_kind == EXTERNAL_FLOAT_ELEMENTS) { 3424 if (elements_kind == EXTERNAL_FLOAT_ELEMENTS ||
3425 elements_kind == FLOAT32_ELEMENTS) {
3425 if (CpuFeatures::IsSupported(SSE2)) { 3426 if (CpuFeatures::IsSupported(SSE2)) {
3426 CpuFeatureScope scope(masm(), SSE2); 3427 CpuFeatureScope scope(masm(), SSE2);
3427 XMMRegister result(ToDoubleRegister(instr->result())); 3428 XMMRegister result(ToDoubleRegister(instr->result()));
3428 __ movss(result, operand); 3429 __ movss(result, operand);
3429 __ cvtss2sd(result, result); 3430 __ cvtss2sd(result, result);
3430 } else { 3431 } else {
3431 X87Mov(ToX87Register(instr->result()), operand, kX87FloatOperand); 3432 X87Mov(ToX87Register(instr->result()), operand, kX87FloatOperand);
3432 } 3433 }
3433 } else if (elements_kind == EXTERNAL_DOUBLE_ELEMENTS) { 3434 } else if (elements_kind == EXTERNAL_DOUBLE_ELEMENTS ||
3435 elements_kind == FLOAT64_ELEMENTS) {
3434 if (CpuFeatures::IsSupported(SSE2)) { 3436 if (CpuFeatures::IsSupported(SSE2)) {
3435 CpuFeatureScope scope(masm(), SSE2); 3437 CpuFeatureScope scope(masm(), SSE2);
3436 __ movsd(ToDoubleRegister(instr->result()), operand); 3438 __ movsd(ToDoubleRegister(instr->result()), operand);
3437 } else { 3439 } else {
3438 X87Mov(ToX87Register(instr->result()), operand); 3440 X87Mov(ToX87Register(instr->result()), operand);
3439 } 3441 }
3440 } else { 3442 } else {
3441 Register result(ToRegister(instr->result())); 3443 Register result(ToRegister(instr->result()));
3442 switch (elements_kind) { 3444 switch (elements_kind) {
3443 case EXTERNAL_BYTE_ELEMENTS: 3445 case EXTERNAL_BYTE_ELEMENTS:
3446 case INT8_ELEMENTS:
3444 __ movsx_b(result, operand); 3447 __ movsx_b(result, operand);
3445 break; 3448 break;
3446 case EXTERNAL_PIXEL_ELEMENTS: 3449 case EXTERNAL_PIXEL_ELEMENTS:
3447 case EXTERNAL_UNSIGNED_BYTE_ELEMENTS: 3450 case EXTERNAL_UNSIGNED_BYTE_ELEMENTS:
3451 case UINT8_ELEMENTS:
3452 case UINT8_CLAMPED_ELEMENTS:
3448 __ movzx_b(result, operand); 3453 __ movzx_b(result, operand);
3449 break; 3454 break;
3450 case EXTERNAL_SHORT_ELEMENTS: 3455 case EXTERNAL_SHORT_ELEMENTS:
3456 case INT16_ELEMENTS:
3451 __ movsx_w(result, operand); 3457 __ movsx_w(result, operand);
3452 break; 3458 break;
3453 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS: 3459 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
3460 case UINT16_ELEMENTS:
3454 __ movzx_w(result, operand); 3461 __ movzx_w(result, operand);
3455 break; 3462 break;
3456 case EXTERNAL_INT_ELEMENTS: 3463 case EXTERNAL_INT_ELEMENTS:
3464 case INT32_ELEMENTS:
3457 __ mov(result, operand); 3465 __ mov(result, operand);
3458 break; 3466 break;
3459 case EXTERNAL_UNSIGNED_INT_ELEMENTS: 3467 case EXTERNAL_UNSIGNED_INT_ELEMENTS:
3468 case UINT32_ELEMENTS:
3460 __ mov(result, operand); 3469 __ mov(result, operand);
3461 if (!instr->hydrogen()->CheckFlag(HInstruction::kUint32)) { 3470 if (!instr->hydrogen()->CheckFlag(HInstruction::kUint32)) {
3462 __ test(result, Operand(result)); 3471 __ test(result, Operand(result));
3463 DeoptimizeIf(negative, instr->environment()); 3472 DeoptimizeIf(negative, instr->environment());
3464 } 3473 }
3465 break; 3474 break;
3466 case EXTERNAL_FLOAT_ELEMENTS: 3475 case EXTERNAL_FLOAT_ELEMENTS:
3467 case EXTERNAL_DOUBLE_ELEMENTS: 3476 case EXTERNAL_DOUBLE_ELEMENTS:
3477 case FLOAT32_ELEMENTS:
3478 case FLOAT64_ELEMENTS:
3468 case FAST_SMI_ELEMENTS: 3479 case FAST_SMI_ELEMENTS:
3469 case FAST_ELEMENTS: 3480 case FAST_ELEMENTS:
3470 case FAST_DOUBLE_ELEMENTS: 3481 case FAST_DOUBLE_ELEMENTS:
3471 case FAST_HOLEY_SMI_ELEMENTS: 3482 case FAST_HOLEY_SMI_ELEMENTS:
3472 case FAST_HOLEY_ELEMENTS: 3483 case FAST_HOLEY_ELEMENTS:
3473 case FAST_HOLEY_DOUBLE_ELEMENTS: 3484 case FAST_HOLEY_DOUBLE_ELEMENTS:
3474 case DICTIONARY_ELEMENTS: 3485 case DICTIONARY_ELEMENTS:
3475 case NON_STRICT_ARGUMENTS_ELEMENTS: 3486 case NON_STRICT_ARGUMENTS_ELEMENTS:
3476 UNREACHABLE(); 3487 UNREACHABLE();
3477 break; 3488 break;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
3530 DeoptimizeIf(not_equal, instr->environment()); 3541 DeoptimizeIf(not_equal, instr->environment());
3531 } else { 3542 } else {
3532 __ cmp(result, factory()->the_hole_value()); 3543 __ cmp(result, factory()->the_hole_value());
3533 DeoptimizeIf(equal, instr->environment()); 3544 DeoptimizeIf(equal, instr->environment());
3534 } 3545 }
3535 } 3546 }
3536 } 3547 }
3537 3548
3538 3549
3539 void LCodeGen::DoLoadKeyed(LLoadKeyed* instr) { 3550 void LCodeGen::DoLoadKeyed(LLoadKeyed* instr) {
3540 if (instr->is_external()) { 3551 if (instr->is_typed_elements()) {
3541 DoLoadKeyedExternalArray(instr); 3552 DoLoadKeyedExternalArray(instr);
3542 } else if (instr->hydrogen()->representation().IsDouble()) { 3553 } else if (instr->hydrogen()->representation().IsDouble()) {
3543 DoLoadKeyedFixedDoubleArray(instr); 3554 DoLoadKeyedFixedDoubleArray(instr);
3544 } else { 3555 } else {
3545 DoLoadKeyedFixedArray(instr); 3556 DoLoadKeyedFixedArray(instr);
3546 } 3557 }
3547 } 3558 }
3548 3559
3549 3560
3550 Operand LCodeGen::BuildFastArrayOperand( 3561 Operand LCodeGen::BuildFastArrayOperand(
3551 LOperand* elements_pointer, 3562 LOperand* elements_pointer,
3552 LOperand* key, 3563 LOperand* key,
3553 Representation key_representation, 3564 Representation key_representation,
3554 ElementsKind elements_kind, 3565 ElementsKind elements_kind,
3555 uint32_t offset, 3566 uint32_t offset,
3556 uint32_t additional_index) { 3567 uint32_t additional_index) {
3557 Register elements_pointer_reg = ToRegister(elements_pointer); 3568 Register elements_pointer_reg = ToRegister(elements_pointer);
3558 int element_shift_size = ElementsKindToShiftSize(elements_kind); 3569 int element_shift_size = ElementsKindToShiftSize(elements_kind);
3570 if (IsFixedTypedArrayElementsKind(elements_kind)) {
3571 offset += FixedTypedArrayBase::kDataOffset - kHeapObjectTag;
3572 }
3559 int shift_size = element_shift_size; 3573 int shift_size = element_shift_size;
3560 if (key->IsConstantOperand()) { 3574 if (key->IsConstantOperand()) {
3561 int constant_value = ToInteger32(LConstantOperand::cast(key)); 3575 int constant_value = ToInteger32(LConstantOperand::cast(key));
3562 if (constant_value & 0xF0000000) { 3576 if (constant_value & 0xF0000000) {
3563 Abort(kArrayIndexConstantValueTooBig); 3577 Abort(kArrayIndexConstantValueTooBig);
3564 } 3578 }
3565 return Operand(elements_pointer_reg, 3579 return Operand(elements_pointer_reg,
3566 ((constant_value + additional_index) << shift_size) 3580 ((constant_value + additional_index) << shift_size)
3567 + offset); 3581 + offset);
3568 } else { 3582 } else {
(...skipping 962 matching lines...) Expand 10 before | Expand all | Expand 10 after
4531 elements_kind)) { 4545 elements_kind)) {
4532 __ SmiUntag(ToRegister(key)); 4546 __ SmiUntag(ToRegister(key));
4533 } 4547 }
4534 Operand operand(BuildFastArrayOperand( 4548 Operand operand(BuildFastArrayOperand(
4535 instr->elements(), 4549 instr->elements(),
4536 key, 4550 key,
4537 instr->hydrogen()->key()->representation(), 4551 instr->hydrogen()->key()->representation(),
4538 elements_kind, 4552 elements_kind,
4539 0, 4553 0,
4540 instr->additional_index())); 4554 instr->additional_index()));
4541 if (elements_kind == EXTERNAL_FLOAT_ELEMENTS) { 4555 if (elements_kind == EXTERNAL_FLOAT_ELEMENTS ||
4556 elements_kind == FLOAT32_ELEMENTS) {
4542 if (CpuFeatures::IsSafeForSnapshot(SSE2)) { 4557 if (CpuFeatures::IsSafeForSnapshot(SSE2)) {
4543 CpuFeatureScope scope(masm(), SSE2); 4558 CpuFeatureScope scope(masm(), SSE2);
4544 XMMRegister xmm_scratch = double_scratch0(); 4559 XMMRegister xmm_scratch = double_scratch0();
4545 __ cvtsd2ss(xmm_scratch, ToDoubleRegister(instr->value())); 4560 __ cvtsd2ss(xmm_scratch, ToDoubleRegister(instr->value()));
4546 __ movss(operand, xmm_scratch); 4561 __ movss(operand, xmm_scratch);
4547 } else { 4562 } else {
4548 __ fld(0); 4563 __ fld(0);
4549 __ fstp_s(operand); 4564 __ fstp_s(operand);
4550 } 4565 }
4551 } else if (elements_kind == EXTERNAL_DOUBLE_ELEMENTS) { 4566 } else if (elements_kind == EXTERNAL_DOUBLE_ELEMENTS ||
4567 elements_kind == FLOAT64_ELEMENTS) {
4552 if (CpuFeatures::IsSafeForSnapshot(SSE2)) { 4568 if (CpuFeatures::IsSafeForSnapshot(SSE2)) {
4553 CpuFeatureScope scope(masm(), SSE2); 4569 CpuFeatureScope scope(masm(), SSE2);
4554 __ movsd(operand, ToDoubleRegister(instr->value())); 4570 __ movsd(operand, ToDoubleRegister(instr->value()));
4555 } else { 4571 } else {
4556 X87Mov(operand, ToX87Register(instr->value())); 4572 X87Mov(operand, ToX87Register(instr->value()));
4557 } 4573 }
4558 } else { 4574 } else {
4559 Register value = ToRegister(instr->value()); 4575 Register value = ToRegister(instr->value());
4560 switch (elements_kind) { 4576 switch (elements_kind) {
4561 case EXTERNAL_PIXEL_ELEMENTS: 4577 case EXTERNAL_PIXEL_ELEMENTS:
4562 case EXTERNAL_UNSIGNED_BYTE_ELEMENTS: 4578 case EXTERNAL_UNSIGNED_BYTE_ELEMENTS:
4563 case EXTERNAL_BYTE_ELEMENTS: 4579 case EXTERNAL_BYTE_ELEMENTS:
4580 case UINT8_ELEMENTS:
4581 case INT8_ELEMENTS:
4582 case UINT8_CLAMPED_ELEMENTS:
4564 __ mov_b(operand, value); 4583 __ mov_b(operand, value);
4565 break; 4584 break;
4566 case EXTERNAL_SHORT_ELEMENTS: 4585 case EXTERNAL_SHORT_ELEMENTS:
4567 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS: 4586 case EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
4587 case UINT16_ELEMENTS:
4588 case INT16_ELEMENTS:
4568 __ mov_w(operand, value); 4589 __ mov_w(operand, value);
4569 break; 4590 break;
4570 case EXTERNAL_INT_ELEMENTS: 4591 case EXTERNAL_INT_ELEMENTS:
4571 case EXTERNAL_UNSIGNED_INT_ELEMENTS: 4592 case EXTERNAL_UNSIGNED_INT_ELEMENTS:
4593 case UINT32_ELEMENTS:
4594 case INT32_ELEMENTS:
4572 __ mov(operand, value); 4595 __ mov(operand, value);
4573 break; 4596 break;
4574 case EXTERNAL_FLOAT_ELEMENTS: 4597 case EXTERNAL_FLOAT_ELEMENTS:
4575 case EXTERNAL_DOUBLE_ELEMENTS: 4598 case EXTERNAL_DOUBLE_ELEMENTS:
4599 case FLOAT32_ELEMENTS:
4600 case FLOAT64_ELEMENTS:
4576 case FAST_SMI_ELEMENTS: 4601 case FAST_SMI_ELEMENTS:
4577 case FAST_ELEMENTS: 4602 case FAST_ELEMENTS:
4578 case FAST_DOUBLE_ELEMENTS: 4603 case FAST_DOUBLE_ELEMENTS:
4579 case FAST_HOLEY_SMI_ELEMENTS: 4604 case FAST_HOLEY_SMI_ELEMENTS:
4580 case FAST_HOLEY_ELEMENTS: 4605 case FAST_HOLEY_ELEMENTS:
4581 case FAST_HOLEY_DOUBLE_ELEMENTS: 4606 case FAST_HOLEY_DOUBLE_ELEMENTS:
4582 case DICTIONARY_ELEMENTS: 4607 case DICTIONARY_ELEMENTS:
4583 case NON_STRICT_ARGUMENTS_ELEMENTS: 4608 case NON_STRICT_ARGUMENTS_ELEMENTS:
4584 UNREACHABLE(); 4609 UNREACHABLE();
4585 break; 4610 break;
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
4703 value, 4728 value,
4704 GetSaveFPRegsMode(), 4729 GetSaveFPRegsMode(),
4705 EMIT_REMEMBERED_SET, 4730 EMIT_REMEMBERED_SET,
4706 check_needed); 4731 check_needed);
4707 } 4732 }
4708 } 4733 }
4709 4734
4710 4735
4711 void LCodeGen::DoStoreKeyed(LStoreKeyed* instr) { 4736 void LCodeGen::DoStoreKeyed(LStoreKeyed* instr) {
4712 // By cases...external, fast-double, fast 4737 // By cases...external, fast-double, fast
4713 if (instr->is_external()) { 4738 if (instr->is_typed_elements()) {
4714 DoStoreKeyedExternalArray(instr); 4739 DoStoreKeyedExternalArray(instr);
4715 } else if (instr->hydrogen()->value()->representation().IsDouble()) { 4740 } else if (instr->hydrogen()->value()->representation().IsDouble()) {
4716 DoStoreKeyedFixedDoubleArray(instr); 4741 DoStoreKeyedFixedDoubleArray(instr);
4717 } else { 4742 } else {
4718 DoStoreKeyedFixedArray(instr); 4743 DoStoreKeyedFixedArray(instr);
4719 } 4744 }
4720 } 4745 }
4721 4746
4722 4747
4723 void LCodeGen::DoStoreKeyedGeneric(LStoreKeyedGeneric* instr) { 4748 void LCodeGen::DoStoreKeyedGeneric(LStoreKeyedGeneric* instr) {
(...skipping 1627 matching lines...) Expand 10 before | Expand all | Expand 10 after
6351 FixedArray::kHeaderSize - kPointerSize)); 6376 FixedArray::kHeaderSize - kPointerSize));
6352 __ bind(&done); 6377 __ bind(&done);
6353 } 6378 }
6354 6379
6355 6380
6356 #undef __ 6381 #undef __
6357 6382
6358 } } // namespace v8::internal 6383 } } // namespace v8::internal
6359 6384
6360 #endif // V8_TARGET_ARCH_IA32 6385 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698