Implement in-heap backing store for typed arrays.

src/objects-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 114 matching lines @@
       break;
     case EXTERNAL_UNSIGNED_INT_ARRAY_TYPE:
       ExternalUnsignedIntArray::cast(this)->ExternalUnsignedIntArrayVerify();
       break;
     case EXTERNAL_FLOAT_ARRAY_TYPE:
       ExternalFloatArray::cast(this)->ExternalFloatArrayVerify();
       break;
     case EXTERNAL_DOUBLE_ARRAY_TYPE:
       ExternalDoubleArray::cast(this)->ExternalDoubleArrayVerify();
       break;
+    case FIXED_UINT8_ARRAY_TYPE:
+      FixedUint8Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_INT8_ARRAY_TYPE:
+      FixedInt8Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_UINT16_ARRAY_TYPE:
+      FixedUint16Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_INT16_ARRAY_TYPE:
+      FixedInt16Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_UINT32_ARRAY_TYPE:
+      FixedUint32Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_INT32_ARRAY_TYPE:
+      FixedInt32Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_FLOAT32_ARRAY_TYPE:
+      FixedFloat32Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_FLOAT64_ARRAY_TYPE:
+      FixedFloat64Array::cast(this)->FixedTypedArrayVerify();
+      break;
+    case FIXED_UINT8_CLAMPED_ARRAY_TYPE:
+      FixedUint8ClampedArray::cast(this)->FixedTypedArrayVerify();
+      break;
     case CODE_TYPE:
       Code::cast(this)->CodeVerify();
       break;
     case ODDBALL_TYPE:
       Oddball::cast(this)->OddballVerify();
       break;
     case JS_OBJECT_TYPE:
     case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
       JSObject::cast(this)->JSObjectVerify();
       break;
@@ skipping 155 matching lines @@
 void ExternalFloatArray::ExternalFloatArrayVerify() {
   CHECK(IsExternalFloatArray());
 }
 
 
 void ExternalDoubleArray::ExternalDoubleArrayVerify() {
   CHECK(IsExternalDoubleArray());
 }
 
 
+template <class Traits>
+void FixedTypedArray<Traits>::FixedTypedArrayVerify() {
+  CHECK(IsHeapObject()
+      && HeapObject::cast(this)->map()->instance_type()

[Toon Verwaest, 2013/12/23 10:40:32]

&& on previous line. Also ==. Indent +4 spaces for the line after ==.

[Dmitry Lomov (no reviews), 2014/01/07 15:48:43]

Done.

+      == Traits::kInstanceType);
+}
+
+
 bool JSObject::ElementsAreSafeToExamine() {
   return (FLAG_use_gvn && FLAG_use_allocation_folding) ||
       reinterpret_cast<Map*>(elements()) !=
       GetHeap()->one_pointer_filler_map();
 }
 
 
 void JSObject::JSObjectVerify() {
   VerifyHeapPointer(properties());
   VerifyHeapPointer(elements());
@@ skipping 760 matching lines @@
       break;
     }
     case EXTERNAL_BYTE_ELEMENTS:
     case EXTERNAL_UNSIGNED_BYTE_ELEMENTS:
     case EXTERNAL_SHORT_ELEMENTS:
     case EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
     case EXTERNAL_INT_ELEMENTS:
     case EXTERNAL_UNSIGNED_INT_ELEMENTS:
     case EXTERNAL_FLOAT_ELEMENTS:
     case EXTERNAL_DOUBLE_ELEMENTS:
-    case EXTERNAL_PIXEL_ELEMENTS: {
+    case EXTERNAL_PIXEL_ELEMENTS:
+    case UINT8_ELEMENTS:
+    case INT8_ELEMENTS:
+    case UINT16_ELEMENTS:
+    case INT16_ELEMENTS:
+    case UINT32_ELEMENTS:
+    case INT32_ELEMENTS:
+    case FLOAT32_ELEMENTS:
+    case FLOAT64_ELEMENTS:
+    case UINT8_CLAMPED_ELEMENTS: {
       info->number_of_objects_with_fast_elements_++;
-      ExternalPixelArray* e = ExternalPixelArray::cast(elements());
+      FixedArrayBase* e = FixedArrayBase::cast(elements());
       info->number_of_fast_used_elements_ += e->length();
       break;
     }
     case DICTIONARY_ELEMENTS: {
       SeededNumberDictionary* dict = element_dictionary();
       info->number_of_slow_used_elements_ += dict->NumberOfElements();
       info->number_of_slow_unused_elements_ +=
           dict->Capacity() - dict->NumberOfElements();
       break;
     }
@@ skipping 94 matching lines @@
   for (int i = 0; i < number_of_transitions(); ++i) {
     if (!CheckOneBackPointer(current_map, GetTarget(i))) return false;
   }
   return true;
 }
 
 
 #endif  // DEBUG
 
 } }  // namespace v8::internal