Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 101413002: [Mojo] Remove dependency between mojo/public and gpu (Closed)

Created:
7 years ago by abarth-chromium
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org
Visibility:
Public.

Description

[Mojo] Remove dependency between mojo/public and gpu This CL restructures how sample_app integrates with the GPU command buffer. Instead of mojo/public containing code that depends directly on gpu/command_buffer, this CL isolates that dependency into a dynamically linked library modelled after mojo_system. 1) mojo/public/gles2 contains a simple C API to libmojo_gles2.so. 2) mojo/gles2 contains a "thin" implementation of this API in terms of gpu/command_buffer. 3) Instead of subclassing GLES2ClientStub in mojo/public/bindings, we now subclass the stub directly in sample_app and control the GLES2 C API via mojo/public/gles2. I've also added a couple of README.md files that describe the purposes of the various directories and the reasons why the code is structured in this way. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238517

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Darin's comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -264 lines) Patch
D mojo/README View 1 chunk +0 lines, -3 lines 0 comments Download
A + mojo/README.md View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/apps/js/bindings/threading.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/examples/sample_app/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
A mojo/examples/sample_app/gles2_client_impl.h View 1 chunk +41 lines, -0 lines 0 comments Download
A mojo/examples/sample_app/gles2_client_impl.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M mojo/examples/sample_app/native_viewport_client_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/examples/sample_app/native_viewport_client_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/examples/sample_app/sample_gles2_delegate.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/examples/sample_app/sample_gles2_delegate.cc View 1 chunk +0 lines, -45 lines 0 comments Download
A + mojo/gles2/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/gles2/README.md View 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/gles2/gles2.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 5 chunks +17 lines, -4 lines 0 comments Download
M mojo/mojo_examples.gypi View 2 chunks +14 lines, -14 lines 0 comments Download
M mojo/mojo_public.gypi View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/mojo_services.gypi View 5 chunks +9 lines, -9 lines 0 comments Download
A mojo/public/README.md View 1 chunk +41 lines, -0 lines 0 comments Download
D mojo/public/bindings/gles2_client/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/bindings/gles2_client/gles2_client_impl.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/public/bindings/gles2_client/gles2_client_impl.cc View 1 chunk +0 lines, -75 lines 0 comments Download
A mojo/public/gles2/gles2.h View 1 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
7 years ago (2013-12-03 08:47:00 UTC) #1
abarth-chromium
After this CL and https://codereview.chromium.org/100573003/, mojo/public should be free of non-test dependencies on base.
7 years ago (2013-12-03 08:48:08 UTC) #2
abarth-chromium
https://codereview.chromium.org/101413002/diff/1/mojo/public/gles2/adaptor.h File mojo/public/gles2/adaptor.h (right): https://codereview.chromium.org/101413002/diff/1/mojo/public/gles2/adaptor.h#newcode39 mojo/public/gles2/adaptor.h:39: // TODO(abarth): MojoGLES2SetContext should take a MojoHandle. MojoGLES2SetContext -> ...
7 years ago (2013-12-03 21:30:45 UTC) #3
darin (slow to review)
LGTM https://codereview.chromium.org/101413002/diff/1/mojo/public/README.md File mojo/public/README.md (right): https://codereview.chromium.org/101413002/diff/1/mojo/public/README.md#newcode1 mojo/public/README.md:1: Mojo Public API Thank you for writing this! ...
7 years ago (2013-12-03 21:39:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/101413002/40001
7 years ago (2013-12-04 00:03:23 UTC) #5
abarth-chromium
7 years ago (2013-12-04 01:15:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r238517 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698