src/compiler/arm/code-generator-arm.cc - Issue 1014093005: [turbofan] Emit constant pool before blocking it in AssembleArchTableSwitch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 1014093005: [turbofan] Emit constant pool before blocking it in AssembleArchTableSwitch. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/arm/code-generator-arm.cc

diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc

index a669808335c9cc4f8405ef053dcb2263a5c6f53f..b9c3476128cd098df3927211c99d483d1e6a9d22 100644

--- a/src/compiler/arm/code-generator-arm.cc

+++ b/src/compiler/arm/code-generator-arm.cc

@@ -802,6 +802,7 @@ void CodeGenerator::AssembleArchTableSwitch(Instruction* instr) {

ArmOperandConverter i(this, instr);

size_t const case_count = instr->InputCount() - 2;

+ __ CheckConstPool(true, true);

__ cmp(input, Operand(case_count));

__ BlockConstPoolFor(case_count + 2);

__ ldr(pc, MemOperand(pc, input, LSL, 2), lo);

« no previous file with comments | « no previous file | no next file » | no next file with comments »