Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1014083003: Return OS status code from python test driver scripts. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Return OS status code from python test driver scripts. Consequently, some of the tests may diff but the waterfall remains green. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2c4f5eaa7bdad0454c311a1cc41f43e4238e4308

Patch Set 1 #

Patch Set 2 : Indent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M testing/tools/run_corpus_tests.py View 1 3 chunks +8 lines, -3 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 2 chunks +8 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, please review. Can't believe I forgot this.
5 years, 9 months ago (2015-03-17 19:26:21 UTC) #1
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-17 20:07:09 UTC) #2
Tom Sepez
5 years, 9 months ago (2015-03-17 20:25:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c4f5eaa7bdad0454c311a1cc41f43e4238e4308 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698