Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: chromeos/dbus/fake_shill_third_party_vpn_driver_client.cc

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/fake_shill_third_party_vpn_driver_client.h" 5 #include "chromeos/dbus/fake_shill_third_party_vpn_driver_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "chromeos/dbus/shill_third_party_vpn_observer.h" 9 #include "chromeos/dbus/shill_third_party_vpn_observer.h"
10 #include "dbus/object_proxy.h" 10 #include "dbus/object_proxy.h"
(...skipping 24 matching lines...) Expand all
35 if (observer_map_.find(object_path_value) == observer_map_.end()) { 35 if (observer_map_.find(object_path_value) == observer_map_.end()) {
36 VLOG(2) << "Observer does not exist."; 36 VLOG(2) << "Observer does not exist.";
37 return; 37 return;
38 } 38 }
39 observer_map_.erase(object_path_value); 39 observer_map_.erase(object_path_value);
40 } 40 }
41 41
42 void FakeShillThirdPartyVpnDriverClient::SetParameters( 42 void FakeShillThirdPartyVpnDriverClient::SetParameters(
43 const std::string& object_path_value, 43 const std::string& object_path_value,
44 const base::DictionaryValue& parameters, 44 const base::DictionaryValue& parameters,
45 const base::Closure& callback, 45 const ShillClientHelper::StringCallback& callback,
46 const ShillClientHelper::ErrorCallback& error_callback) { 46 const ShillClientHelper::ErrorCallback& error_callback) {
47 base::MessageLoop::current()->PostTask(FROM_HERE, callback); 47 base::MessageLoop::current()->PostTask(FROM_HERE,
48 base::Bind(callback, std::string()));
48 } 49 }
49 50
50 void FakeShillThirdPartyVpnDriverClient::UpdateConnectionState( 51 void FakeShillThirdPartyVpnDriverClient::UpdateConnectionState(
51 const std::string& object_path_value, 52 const std::string& object_path_value,
52 const uint32_t connection_state, 53 const uint32_t connection_state,
53 const base::Closure& callback, 54 const base::Closure& callback,
54 const ShillClientHelper::ErrorCallback& error_callback) { 55 const ShillClientHelper::ErrorCallback& error_callback) {
55 base::MessageLoop::current()->PostTask(FROM_HERE, callback); 56 base::MessageLoop::current()->PostTask(FROM_HERE, callback);
56 } 57 }
57 58
(...skipping 28 matching lines...) Expand all
86 87
87 it->second->OnPlatformMessage(message); 88 it->second->OnPlatformMessage(message);
88 } 89 }
89 90
90 ShillThirdPartyVpnDriverClient::TestInterface* 91 ShillThirdPartyVpnDriverClient::TestInterface*
91 FakeShillThirdPartyVpnDriverClient::GetTestInterface() { 92 FakeShillThirdPartyVpnDriverClient::GetTestInterface() {
92 return this; 93 return this;
93 } 94 }
94 95
95 } // namespace chromeos 96 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698