Clear alternate protocols on empty or invalid header

Clear alternate protocols for an origin when an empty or invalid Alternate-Protocol header is processed.

Committed: https://crrev.com/89c6e105b28e7219991a8d452576c0c0f577e394
Cr-Commit-Position: refs/heads/master@{#321180}

[Ryan Hamilton, 2015-03-17 19:29:10]

rch@chromium.org changed reviewers:
+ bnc@chromium.org

[Bence, 2015-03-17 19:43:11]

Hi Ryan,

If the alternate protocol header is non-empty but malformed, that's a noop, see
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre....
 Is that what we want, or do we want to clear the mapping in that case too?

Why is this the best place for the clearing logic, and not
HttpStreamFactory::ProcessAlternateProtocol?  Especially if we want to clear on
malformed header too.

FYI these unittests will have a merge conflict with
https://crrev.com/1017453008.

[Ryan Hamilton, 2015-03-17 20:12:50]

On 2015/03/17 19:43:11, Bence wrote:
> Hi Ryan,
> 
> If the alternate protocol header is non-empty but malformed, that's a noop,
see
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre....
>  Is that what we want, or do we want to clear the mapping in that case too?
> 
> Why is this the best place for the clearing logic, and not
> HttpStreamFactory::ProcessAlternateProtocol?  Especially if we want to clear
on
> malformed header too.

Good point. Done.

> FYI these unittests will have a merge conflict with
> https://crrev.com/1017453008.

Roger that.

[Bence, 2015-03-17 20:40:23]

LGTM.  Maybe you could prefix the CL description with a one-line summary like
"Clear alternate protocols on empty header value" or similar.

[Ryan Hamilton, 2015-03-17 20:52:51]

On 2015/03/17 20:40:23, Bence wrote:
> LGTM.  Maybe you could prefix the CL description with a one-line summary like
> "Clear alternate protocols on empty header value" or similar.

Done.

[Ryan Hamilton, 2015-03-18 03:14:32]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-03-18 03:14:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/1014043004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-18 03:14:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014043004/40001

[commit-bot: I haz the power, 2015-03-18 03:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-18 03:30:30]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Ryan Hamilton, 2015-03-18 17:47:18]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-03-18 17:47:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/1014043004/#ps60001
(title: "Fix in response to broken test")

[commit-bot: I haz the power, 2015-03-18 17:47:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014043004/60001

[commit-bot: I haz the power, 2015-03-18 18:57:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-18 18:57:34]

Patchset 4 (id:??) landed as
https://crrev.com/89c6e105b28e7219991a8d452576c0c0f577e394
Cr-Commit-Position: refs/heads/master@{#321180}