Issue 1014005: Attempt at pre-calculating replace regexp matches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1014005: Attempt at pre-calculating replace regexp matches. (Closed)

Created:
10 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
sandholm, antonm

CC:
v8-dev

Visibility:
Public.

Description

Attempt at pre-calculating replace regexp matches.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reuse result array. Avoid using apply. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -91 lines)			Patch
M	src/jsregexp.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	4 chunks	+130 lines, -18 lines	0 comments	Download
M	src/string.js	View	1	2 chunks	+65 lines, -73 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

10 years, 9 months ago (2010-03-17 11:29:54 UTC) #2

drive-by comment

http://codereview.chromium.org/1014005/diff/1/2
File src/jsregexp.h (right):

http://codereview.chromium.org/1014005/diff/1/2#newcode152
src/jsregexp.h:152: return (re->get(JSRegExp::kTagIndex) ==
Smi::FromInt(JSRegExp::ATOM))
maybe RegExpIsAtom(re) ? 0 : Irre... ?

Expand Messages | Collapse Messages