Added definition of the policy DeviceLoginScreenDomainAutoComplete.

Added definition of the policy DeviceLoginScreenDomainAutoComplete.

BUG=468778
Committed: https://crrev.com/1be34e7194d2743b1facc7dcca77e84a0f19fe06
Cr-Commit-Position: refs/heads/master@{#321968}

[peletskyi, 2015-03-23 14:46:28]

peletskyi@chromium.org changed reviewers:
+ atwilson@chromium.org, bartfab@chromium.org, isherman@chromium.org

[peletskyi, 2015-03-23 14:46:28]

Please take a look at my changes.

[Andrew T Wilson (Slow), 2015-03-23 14:51:20]

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:469: // If this
policy is set to a blank string or not configured, an autocomplete
nit: change this to "If this policy is not configured or set to a blank screen,
no autocomplete option during user sign-in flow will be shown"

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:475: optional
string device_login_screen_domain_auto_complete = 6;
nit: name this login_screen_domain_auto_complete (remove the device_)

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/policy/confi...
File chrome/browser/policy/configuration_policy_handler_list_factory.cc (right):

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/policy/confi...
chrome/browser/policy/configuration_policy_handler_list_factory.cc:473: {
key::kDeviceLoginScreenDefaultLargeCursorEnabled,
What's this (LargeCursorEnabled?)

[peletskyi, 2015-03-23 15:25:40]

PTAL

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:469: // If this
policy is set to a blank string or not configured, an autocomplete
On 2015/03/23 14:51:20, Andrew T Wilson wrote:
> nit: change this to "If this policy is not configured or set to a blank
screen,
> no autocomplete option during user sign-in flow will be shown"

Done.

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:475: optional
string device_login_screen_domain_auto_complete = 6;
On 2015/03/23 14:51:20, Andrew T Wilson wrote:
> nit: name this login_screen_domain_auto_complete (remove the device_)

Done.

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/policy/confi...
File chrome/browser/policy/configuration_policy_handler_list_factory.cc (right):

https://codereview.chromium.org/1014003004/diff/1/chrome/browser/policy/confi...
chrome/browser/policy/configuration_policy_handler_list_factory.cc:473: {
key::kDeviceLoginScreenDefaultLargeCursorEnabled,
On 2015/03/23 14:51:20, Andrew T Wilson wrote:
> What's this (LargeCursorEnabled?)

Copy-paste error :)

[Andrew T Wilson (Slow), 2015-03-23 16:02:03]

LGTM with one nit

https://codereview.chromium.org/1014003004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):

https://codereview.chromium.org/1014003004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:599: if
(container.has_login_screen_domain_auto_complete() &&
Add a comment about why we're doing the empty() check.

[peletskyi, 2015-03-23 16:19:29]

Done

https://codereview.chromium.org/1014003004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):

https://codereview.chromium.org/1014003004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:599: if
(container.has_login_screen_domain_auto_complete() &&
On 2015/03/23 16:02:02, Andrew T Wilson wrote:
> Add a comment about why we're doing the empty() check.

Done.

[Ilya Sherman, 2015-03-23 22:10:29]

histograms.xml lgtm

[peletskyi, 2015-03-24 09:12:11]

The CQ bit was checked by peletskyi@chromium.org

[peletskyi, 2015-03-24 09:12:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/1014003004/#ps40001
(title: "Added comments")

[commit-bot: I haz the power, 2015-03-24 09:12:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014003004/40001

[commit-bot: I haz the power, 2015-03-24 11:18:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-24 11:19:13]

Patchset 3 (id:??) landed as
https://crrev.com/1be34e7194d2743b1facc7dcca77e84a0f19fe06
Cr-Commit-Position: refs/heads/master@{#321968}