Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 1014003002: [bindings] Remove the last traces of V8RethrowTryCatchScope from V8Binding.h (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Remove the last traces of V8RethrowTryCatchScope from V8Binding.h CL [1] introduced the V8RethrowTryCatchScope for auto rethrowing but is no longer used. Removing the class declaration as unused code. If required, can be revived back by time travel in the past :) [1] https://codereview.chromium.org/304223007 R=jl@opera.com, haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL, thanks.
5 years, 9 months ago (2015-03-17 08:15:24 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-17 08:15:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014003002/1
5 years, 9 months ago (2015-03-17 08:16:26 UTC) #5
Jens Widell
LGTM
5 years, 9 months ago (2015-03-17 08:20:38 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 09:18:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191988

Powered by Google App Engine
This is Rietveld 408576698