Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1013973002: [Files.app] Use dictionary-way to access Entry.cachedUrl (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Use dictionary-way to access Entry.cachedUrl Entry.cachedUrl is not standard property and the closure compiler detected it as an error. To prevent the error, we need to access it with dictionary-way (using brackets). BUG=448263 TEST=none Committed: https://crrev.com/9dd3b7f9c09d32aa6fa914ac48e85df2f9de4437 Cr-Commit-Position: refs/heads/master@{#320873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 1 chunk +3 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.,
5 years, 9 months ago (2015-03-17 05:02:57 UTC) #2
fukino
lgtm.
5 years, 9 months ago (2015-03-17 05:14:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013973002/1
5 years, 9 months ago (2015-03-17 05:20:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 05:47:53 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 05:49:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dd3b7f9c09d32aa6fa914ac48e85df2f9de4437
Cr-Commit-Position: refs/heads/master@{#320873}

Powered by Google App Engine
This is Rietveld 408576698