Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1013943002: Add SetStartupCurrent to monsoon profiler. (Closed)

Created:
5 years, 9 months ago by JungJik
Modified:
5 years, 9 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SetStartupCurrent to monsoon profiler. Some devices which use exnynos need more ampere to boot up at the initial time. In this case, the StartUpCurrent should be set to 5 at least. SetStartupCurrent function is for setting the initial ampere value in monsoon profiler. Committed: https://crrev.com/be5c4cf63ecb22e646784d114a77d4fbfe360862 Cr-Commit-Position: refs/heads/master@{#321284}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add unit desc and change const value from int to float #

Total comments: 2

Patch Set 3 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/monsoon.py View 1 2 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
JungJik
PTAL
5 years, 9 months ago (2015-03-17 04:14:32 UTC) #2
tonyg
https://codereview.chromium.org/1013943002/diff/1/tools/telemetry/telemetry/core/platform/profiler/monsoon.py File tools/telemetry/telemetry/core/platform/profiler/monsoon.py (right): https://codereview.chromium.org/1013943002/diff/1/tools/telemetry/telemetry/core/platform/profiler/monsoon.py#newcode160 tools/telemetry/telemetry/core/platform/profiler/monsoon.py:160: """Set the max startup output current.""" It'd be nice ...
5 years, 9 months ago (2015-03-17 13:58:28 UTC) #4
JungJik
https://codereview.chromium.org/1013943002/diff/1/tools/telemetry/telemetry/core/platform/profiler/monsoon.py File tools/telemetry/telemetry/core/platform/profiler/monsoon.py (right): https://codereview.chromium.org/1013943002/diff/1/tools/telemetry/telemetry/core/platform/profiler/monsoon.py#newcode160 tools/telemetry/telemetry/core/platform/profiler/monsoon.py:160: """Set the max startup output current.""" On 2015/03/17 13:58:28, ...
5 years, 9 months ago (2015-03-18 10:21:28 UTC) #5
dtu
lgtm with nit https://codereview.chromium.org/1013943002/diff/20001/tools/telemetry/telemetry/core/platform/profiler/monsoon.py File tools/telemetry/telemetry/core/platform/profiler/monsoon.py (right): https://codereview.chromium.org/1013943002/diff/20001/tools/telemetry/telemetry/core/platform/profiler/monsoon.py#newcode160 tools/telemetry/telemetry/core/platform/profiler/monsoon.py:160: """Set the max startup output current. ...
5 years, 9 months ago (2015-03-18 21:26:19 UTC) #6
JungJik
thanks for the review. https://codereview.chromium.org/1013943002/diff/20001/tools/telemetry/telemetry/core/platform/profiler/monsoon.py File tools/telemetry/telemetry/core/platform/profiler/monsoon.py (right): https://codereview.chromium.org/1013943002/diff/20001/tools/telemetry/telemetry/core/platform/profiler/monsoon.py#newcode160 tools/telemetry/telemetry/core/platform/profiler/monsoon.py:160: """Set the max startup output ...
5 years, 9 months ago (2015-03-19 02:26:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013943002/40001
5 years, 9 months ago (2015-03-19 02:27:22 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 03:45:10 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 03:46:15 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be5c4cf63ecb22e646784d114a77d4fbfe360862
Cr-Commit-Position: refs/heads/master@{#321284}

Powered by Google App Engine
This is Rietveld 408576698