Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 101393006: FileAPI: Rename *OnFileThread to *OnFileTaskRunner (Closed)

Created:
7 years ago by nhiroki
Modified:
7 years ago
CC:
chromium-reviews, tzik, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, markusheintz_, kinuko+watch
Visibility:
Public.

Description

FileAPI: Rename *OnFileThread to *OnFileTaskRunner This renames *OnFileThread methods to *OnFileTaskRunner because now they run not on FILE thread but on file_task_runner. And also adds some DCHECK for checking valid task_runner into SandboxFileSystemBackendDelegate. BUG=n/a TEST=n/a TBR=michaeln@chromium.org,phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242072

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
nhiroki
PTAL, thanks!
7 years ago (2013-12-20 04:48:56 UTC) #1
kinuko
lgtm
7 years ago (2013-12-20 05:38:45 UTC) #2
nhiroki
Renaming only, so let me tbr to... - michaeln@ for chrome/browser/browsing_data/ - phajdan.jr@ for content/public/test/
7 years ago (2013-12-20 09:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/101393006/1
7 years ago (2013-12-20 09:58:12 UTC) #4
Paweł Hajdan Jr.
content/public/test LGTM
7 years ago (2013-12-20 11:51:20 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-20 12:27:42 UTC) #6
Message was sent while issue was closed. 
Change committed as 242072

Powered by Google App Engine
This is Rietveld 408576698