Source/modules/mediasource/SourceBuffer.h - Issue 1013923002: Fix MSE GC, make it less aggressive, more spec-compliant (Blink CL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediasource/SourceBuffer.h

Issue 1013923002: Fix MSE GC, make it less aggressive, more spec-compliant (Blink CL) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added decodeError parameter for appendError function Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/media/media-source/mediasource-evict-frames.html ('K') | « LayoutTests/http/tests/media/media-source/mediasource-evict-frames.html ('k') | Source/modules/mediasource/SourceBuffer.cpp » ('j') | Source/modules/mediasource/SourceBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediasource/SourceBuffer.h

diff --git a/Source/modules/mediasource/SourceBuffer.h b/Source/modules/mediasource/SourceBuffer.h

index 3c033eb50420ce873a3419547454b140a8239bed..4d1152bdd9b16624f2e5f39b7c18583c9cebc27b 100644

--- a/Source/modules/mediasource/SourceBuffer.h

+++ b/Source/modules/mediasource/SourceBuffer.h

@@ -121,6 +121,9 @@ private:

void appendStreamAsyncPart();

void appendStreamDone(bool success);

void clearAppendStreamState();

+ void appendError(bool decodeError);

+ bool evictCodedFrames();

// FileReaderLoaderClient interface

virtual void didStartLoading() override;