Source/modules/mediasource/SourceBuffer.h - Issue 1013923002: Fix MSE GC, make it less aggressive, more spec-compliant (Blink CL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediasource/SourceBuffer.h

Issue 1013923002: Fix MSE GC, make it less aggressive, more spec-compliant (Blink CL) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: m_loader might be released before didFail, if appendStream failed due to full buffer Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/mediasource/SourceBuffer.h

diff --git a/Source/modules/mediasource/SourceBuffer.h b/Source/modules/mediasource/SourceBuffer.h

index 093f7694396ec1990e79ba0443dc64da0a213976..32af18e5cda5d7ca7078df5c0f51fd9d0f670bc4 100644

--- a/Source/modules/mediasource/SourceBuffer.h

+++ b/Source/modules/mediasource/SourceBuffer.h

@@ -114,8 +114,11 @@ private:

bool isRemoved() const;

void scheduleEvent(const AtomicString& eventName);

+ bool prepareAppend(size_t newDataSize, ExceptionState&);

+ bool evictCodedFrames(size_t newDataSize);

void appendBufferInternal(const unsigned char*, unsigned, ExceptionState&);

void appendBufferAsyncPart();

+ void appendError(bool decodeError);

void removeAsyncPart();

« no previous file with comments | « Source/modules/mediasource/MediaSource.cpp ('k') | Source/modules/mediasource/SourceBuffer.cpp » ('j') | no next file with comments »