Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: public/platform/WebSourceBuffer.h

Issue 1013923002: Fix MSE GC, make it less aggressive, more spec-compliant (Blink CL) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: m_loader might be released before didFail, if appendStream failed due to full buffer Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 virtual ~WebSourceBuffer() { } 47 virtual ~WebSourceBuffer() { }
48 48
49 // This will only be called once and only with a non-null pointer to a 49 // This will only be called once and only with a non-null pointer to a
50 // client whose ownership is not transferred to this WebSourceBuffer. 50 // client whose ownership is not transferred to this WebSourceBuffer.
51 virtual void setClient(WebSourceBufferClient*) = 0; 51 virtual void setClient(WebSourceBufferClient*) = 0;
52 52
53 virtual bool setMode(AppendMode) = 0; 53 virtual bool setMode(AppendMode) = 0;
54 virtual WebTimeRanges buffered() = 0; 54 virtual WebTimeRanges buffered() = 0;
55 55
56 // Run coded frame eviction/garbage collection algorithm.
57 // |currentPlaybackTime| is HTMLMediaElement::currentTime. The algorithm
58 // will try to preserve data around current playback position.
59 // |newDataSize| is size of new data about to be appended to SourceBuffer.
60 // Could be zero for appendStream if stream size is unknown in advance.
61 // Returns false if buffer is still full after eviction.
62 virtual bool evictCodedFrames(double currentPlaybackTime, size_t newDataSize ) = 0;
63
56 // Appends data and runs the segment parser loop algorithm. 64 // Appends data and runs the segment parser loop algorithm.
57 // The algorithm may update |*timestampOffset| if |timestampOffset| is not n ull. 65 // The algorithm may update |*timestampOffset| if |timestampOffset| is not n ull.
58 virtual void append(const unsigned char* data, unsigned length, double* time stampOffset) = 0; 66 virtual void append(const unsigned char* data, unsigned length, double* time stampOffset) = 0;
59 67
60 virtual void abort() = 0; 68 virtual void abort() = 0;
61 virtual void remove(double start, double end) = 0; 69 virtual void remove(double start, double end) = 0;
62 virtual bool setTimestampOffset(double) = 0; 70 virtual bool setTimestampOffset(double) = 0;
63 71
64 // Set presentation timestamp for the start of append window. 72 // Set presentation timestamp for the start of append window.
65 virtual void setAppendWindowStart(double) = 0; 73 virtual void setAppendWindowStart(double) = 0;
66 74
67 // Set presentation timestamp for the end of append window. 75 // Set presentation timestamp for the end of append window.
68 virtual void setAppendWindowEnd(double) = 0; 76 virtual void setAppendWindowEnd(double) = 0;
69 77
70 // After this method is called, this WebSourceBuffer should never use the 78 // After this method is called, this WebSourceBuffer should never use the
71 // client pointer passed to setClient(). 79 // client pointer passed to setClient().
72 virtual void removedFromMediaSource() = 0; 80 virtual void removedFromMediaSource() = 0;
73 }; 81 };
74 82
75 } // namespace blink 83 } // namespace blink
76 84
77 #endif 85 #endif
OLDNEW
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698