Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: Source/modules/mediasource/MediaSource.h

Issue 1013923002: Fix MSE GC, make it less aggressive, more spec-compliant (Blink CL) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: m_loader might be released before didFail, if appendStream failed due to full buffer Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/modules/mediasource/MediaSource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 bool hasPendingActivity() const override; 94 bool hasPendingActivity() const override;
95 void stop() override; 95 void stop() override;
96 96
97 // URLRegistrable interface 97 // URLRegistrable interface
98 URLRegistry& registry() const override; 98 URLRegistry& registry() const override;
99 99
100 // Used by SourceBuffer. 100 // Used by SourceBuffer.
101 void openIfInEndedState(); 101 void openIfInEndedState();
102 bool isOpen() const; 102 bool isOpen() const;
103 void setSourceBufferActive(SourceBuffer*); 103 void setSourceBufferActive(SourceBuffer*);
104 HTMLMediaElement* mediaElement() const;
104 105
105 // Used by MediaSourceRegistry. 106 // Used by MediaSourceRegistry.
106 void addedToRegistry(); 107 void addedToRegistry();
107 void removedFromRegistry(); 108 void removedFromRegistry();
108 109
109 DECLARE_VIRTUAL_TRACE(); 110 DECLARE_VIRTUAL_TRACE();
110 111
111 private: 112 private:
112 explicit MediaSource(ExecutionContext*); 113 explicit MediaSource(ExecutionContext*);
113 114
(...skipping 17 matching lines...) Expand all
131 132
132 Member<SourceBufferList> m_sourceBuffers; 133 Member<SourceBufferList> m_sourceBuffers;
133 Member<SourceBufferList> m_activeSourceBuffers; 134 Member<SourceBufferList> m_activeSourceBuffers;
134 135
135 bool m_isAddedToRegistry; 136 bool m_isAddedToRegistry;
136 }; 137 };
137 138
138 } // namespace blink 139 } // namespace blink
139 140
140 #endif // MediaSource_h 141 #endif // MediaSource_h
OLDNEW
« no previous file with comments | « no previous file | Source/modules/mediasource/MediaSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698