Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: Source/modules/mediasource/SourceBuffer.h

Issue 1013923002: Fix MSE GC, make it less aggressive, more spec-compliant (Blink CL) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: CR feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 // Oilpan: eagerly release owned m_webSourceBuffer 107 // Oilpan: eagerly release owned m_webSourceBuffer
108 EAGERLY_FINALIZE(); 108 EAGERLY_FINALIZE();
109 DECLARE_VIRTUAL_TRACE(); 109 DECLARE_VIRTUAL_TRACE();
110 110
111 private: 111 private:
112 SourceBuffer(PassOwnPtr<WebSourceBuffer>, MediaSource*, GenericEventQueue*); 112 SourceBuffer(PassOwnPtr<WebSourceBuffer>, MediaSource*, GenericEventQueue*);
113 113
114 bool isRemoved() const; 114 bool isRemoved() const;
115 void scheduleEvent(const AtomicString& eventName); 115 void scheduleEvent(const AtomicString& eventName);
116 116
117 bool prepareAppend(ExceptionState&);
118 bool evictCodedFrames();
117 void appendBufferInternal(const unsigned char*, unsigned, ExceptionState&); 119 void appendBufferInternal(const unsigned char*, unsigned, ExceptionState&);
118 void appendBufferAsyncPart(); 120 void appendBufferAsyncPart();
121 void appendError(bool decodeError);
119 122
120 void removeAsyncPart(); 123 void removeAsyncPart();
121 124
122 void appendStreamInternal(Stream*, ExceptionState&); 125 void appendStreamInternal(Stream*, ExceptionState&);
123 void appendStreamAsyncPart(); 126 void appendStreamAsyncPart();
124 void appendStreamDone(bool success); 127 void appendStreamDone(bool success);
125 void clearAppendStreamState(); 128 void clearAppendStreamState();
126 129
127 // FileReaderLoaderClient interface 130 // FileReaderLoaderClient interface
128 virtual void didStartLoading() override; 131 virtual void didStartLoading() override;
(...skipping 24 matching lines...) Expand all
153 bool m_streamMaxSizeValid; 156 bool m_streamMaxSizeValid;
154 unsigned long long m_streamMaxSize; 157 unsigned long long m_streamMaxSize;
155 AsyncMethodRunner<SourceBuffer> m_appendStreamAsyncPartRunner; 158 AsyncMethodRunner<SourceBuffer> m_appendStreamAsyncPartRunner;
156 Member<Stream> m_stream; 159 Member<Stream> m_stream;
157 OwnPtr<FileReaderLoader> m_loader; 160 OwnPtr<FileReaderLoader> m_loader;
158 }; 161 };
159 162
160 } // namespace blink 163 } // namespace blink
161 164
162 #endif // SourceBuffer_h 165 #endif // SourceBuffer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698