Update ImportHistory with support for reading history from multiple files.

Update ImportHistory with support for reading history from multiple files.

Refactor history loading, eliminating the obsolete (and even obstructionist) ChromeSyncFileEntryProvider.
This CL updates the entire stack with support for multiple history files, but doesn't yet load all history files. That support will come in a subsequent change.
Remove extra "." qualifier in most instance of "Promise.<" and "Array.<" in affected files only.

TEST=*ImportHistory*

Committed: https://crrev.com/99d6eed3e1370b4a21f00f97f232561e65fa7e6c
Cr-Commit-Position: refs/heads/master@{#320934}

[Steve McKay, 2015-03-16 23:29:31]

Self review

[Steve McKay, 2015-03-16 23:29:41]

Patchset #1 (id:1) has been deleted

[Steve McKay, 2015-03-16 23:36:44]

Self review

[Steve McKay, 2015-03-16 23:36:59]

Patchset #1 (id:20001) has been deleted

[Steve McKay, 2015-03-16 23:43:10]

Self review.

[Steve McKay, 2015-03-16 23:43:16]

Patchset #1 (id:40001) has been deleted

[Steve McKay, 2015-03-16 23:44:43]

smckay@chromium.org changed reviewers:
+ hirono@chromium.org

[Steve McKay, 2015-03-16 23:44:43]

This is a task from the Cloud import backlog (no associated bug). We currently
load history only from the local machine. This CL is one of two adding support
for loading history from other devices as written to sync storage.

[hirono, 2015-03-17 01:02:18]

lgtm!

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/import_history.js (right):

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/import_history.js:500: .catch(
nit: You can pass the catch callback as the second argument of previous then.
Difference is the second argument of then does not suppress exceptions thrown by
the first argument of then. (Current if an exception is thrown while it notifies
the IMPORTED state, we obtain 'Unable to lookup original entry' log in the
console.)

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/import_history_unittest.js
(right):

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/import_history_unittest.js:349: *
@return {!Promise<!Array<!FileEntry>>}
nit: Please fix the return type.

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:512: *
nit: Please remove the empty line.

[Steve McKay, 2015-03-17 17:00:08]

Dones. Thanks!

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/import_history.js (right):

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/import_history.js:500: .catch(
On 2015/03/17 01:02:17, hirono wrote:
> nit: You can pass the catch callback as the second argument of previous then.
> Difference is the second argument of then does not suppress exceptions thrown
by
> the first argument of then. (Current if an exception is thrown while it
notifies
> the IMPORTED state, we obtain 'Unable to lookup original entry' log in the
> console.)
> 

Thanks for the tip. Got this worked out correctly now (as best I understand
Promise error handling).

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/import_history_unittest.js
(right):

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/import_history_unittest.js:349: *
@return {!Promise<!Array<!FileEntry>>}
On 2015/03/17 01:02:17, hirono wrote:
> nit: Please fix the return type.

Done.

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/1013893002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:512: *
On 2015/03/17 01:02:17, hirono wrote:
> nit: Please remove the empty line.

Done.

[Steve McKay, 2015-03-17 17:00:26]

Respond to review comments.

[Steve McKay, 2015-03-17 17:00:55]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-03-17 17:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/1013893002/#ps70001
(title: "Respond to review comments.")

[commit-bot: I haz the power, 2015-03-17 17:01:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1013893002/70001

[commit-bot: I haz the power, 2015-03-17 17:30:55]

Committed patchset #2 (id:70001)

[commit-bot: I haz the power, 2015-03-17 17:31:48]

Patchset 2 (id:??) landed as
https://crrev.com/99d6eed3e1370b4a21f00f97f232561e65fa7e6c
Cr-Commit-Position: refs/heads/master@{#320934}