android_webview/browser/icon_helper.cc - Issue 1013843002: favor DCHECK_CURRENTLY_ON for better logs in android_webview/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/icon_helper.cc

Issue 1013843002: favor DCHECK_CURRENTLY_ON for better logs in android_webview/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change a few more Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/icon_helper.cc

diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc

index 320fcd49a6611b7a3981827b355e178bc57ae55b..7ef757f39680d506b2a47fcbb91ccf7efe46f398 100644

--- a/android_webview/browser/icon_helper.cc

+++ b/android_webview/browser/icon_helper.cc

@@ -38,7 +38,7 @@ void IconHelper::DownloadFaviconCallback(

const GURL& image_url,

const std::vector<SkBitmap>& bitmaps,

const std::vector<gfx::Size>& original_bitmap_sizes) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (http_status_code == 404) {

MarkUnableToDownloadFavicon(image_url);

return;

@@ -59,7 +59,7 @@ void IconHelper::DownloadFaviconCallback(

void IconHelper::DidUpdateFaviconURL(

const std::vector<content::FaviconURL>& candidates) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

for (std::vector<content::FaviconURL>::const_iterator i = candidates.begin();

i != candidates.end(); ++i) {

if (!i->icon_url.is_valid())

« no previous file with comments | « android_webview/browser/aw_resource_context.cc ('k') | android_webview/browser/net/aw_network_delegate.cc » ('j') | no next file with comments »