chrome/browser/resources/settings/settings_main/settings_main.html - Issue 1013833003: Show Pages in chrome://md-settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 1013833003: Show Pages in chrome://md-settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move paper-shadow into pages to avoid layout problem Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index 85eee63481502718bacd83bc299165aae2a92112..ba68d1c80437c258312f4864e517eea61bc68448 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -2,19 +2,23 @@

+<link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">

+<link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html">

<polymer-element name="cr-settings-main">

- <paper-shadow>

- <content select="core-icon-button"></content>

- <core-animated-pages id="pageContainer" selected="{{selectedPageId}}"

- valueattr="PAGE_ID" transitions="cross-fade">

- <cr-settings-dummy-page prefs="{{prefs}}"></cr-settings-dummy-page>

- </core-animated-pages>

- </paper-shadow>

+ <content select="core-icon-button"></content>

+ <core-animated-pages id="pageContainer" selected="{{selectedPageId}}"

+ valueattr="PAGE_ID" transitions="cross-fade"

+ on-core-animated-pages-transition-prepare="{{pageTransitionPrepared_}}">

Jeremy Klein 2015/03/18 01:58:30 We don't need the event listener anymore, right?

michaelpg 2015/03/18 02:07:22 Done.

+ <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>

+ <cr-settings-downloads-page prefs="{{prefs}}">

+ </cr-settings-downloads-page>

+ <cr-settings-dummy-page prefs="{{prefs}}"></cr-settings-dummy-page>

+ </core-animated-pages>

</div>

</template>