Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1013833002: PPC: Changes to allow AIX to compile with gcc 4.8.3 (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Changes to allow AIX to compile with gcc 4.8.3 We were able to remove most of our changes needed to compile on AIX with an earlier compiler level. These changes are the remaining ones. The changes in heap/heap.cc are needed because otherwise the compiler complains that result is potentially used before it is initialized. The changes in heap/mark-compact.cc are required because AIX supports the full 64 bit address range so the check being guarded is invalid. The changes in build/toolchain.gypi and test/cctest/cctest/gyp are aix only and are adjust the compile/link options to allow the AIX build to succeed. modified: build/toolchain.gypi modified: src/heap/heap.cc modified: src/heap/mark-compact.cc modified: test/cctest/cctest.gyp R=danno@chromium.org, svenpanne@chromium.org BUG= Committed: https://crrev.com/8685219066d49995219328d39bbff9ea05f6a60c Cr-Commit-Position: refs/heads/master@{#27255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/toolchain.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
Some minor changes to support compiling on AIX with gcc 4.8.3
5 years, 9 months ago (2015-03-16 21:29:13 UTC) #1
Sven Panne
lgtm
5 years, 9 months ago (2015-03-17 07:19:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013833002/1
5 years, 9 months ago (2015-03-18 08:07:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 08:43:25 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 08:43:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8685219066d49995219328d39bbff9ea05f6a60c
Cr-Commit-Position: refs/heads/master@{#27255}

Powered by Google App Engine
This is Rietveld 408576698