Eliminates gap at the top and bottom of docked area

Eliminates gap at the top and bottom of docked area

BUG=331872
TEST=Visual
 Dock one browser window - should take all vertical space.
 Dock two browser windows - should reach to top / bottom of the docked area.
TEST=ash_unittests --gtest_filter=*Dock*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243236

[varkha, 2014-01-06 20:36:25]

jamescook@, can you please take a look at this little polish? One of the
feedback items I had was to remove the gap at the top and bottom, I think it
looks better, especially now that the docked background is in sync with the
shelf. Thanks!

[James Cook, 2014-01-06 21:06:53]

LGTM

https://codereview.chromium.org/101383004/diff/30001/ash/wm/dock/docked_windo...
File ash/wm/dock/docked_window_layout_manager.cc (right):

https://codereview.chromium.org/101383004/diff/30001/ash/wm/dock/docked_windo...
ash/wm/dock/docked_window_layout_manager.cc:822: available_room -=
(GetWindowHeightCloseTo(child, 0));
nit: Don't need parens around GetWindowHeight().

https://codereview.chromium.org/101383004/diff/30001/ash/wm/dock/docked_windo...
ash/wm/dock/docked_window_layout_manager.cc:1073: const float delta =
(float)available_room /
nit: static_cast<float>

[varkha, 2014-01-06 21:14:04]

Thanks for the quick review!

https://codereview.chromium.org/101383004/diff/30001/ash/wm/dock/docked_windo...
File ash/wm/dock/docked_window_layout_manager.cc (right):

https://codereview.chromium.org/101383004/diff/30001/ash/wm/dock/docked_windo...
ash/wm/dock/docked_window_layout_manager.cc:822: available_room -=
(GetWindowHeightCloseTo(child, 0));
On 2014/01/06 21:06:53, James Cook wrote:
> nit: Don't need parens around GetWindowHeight().

Done.

https://codereview.chromium.org/101383004/diff/30001/ash/wm/dock/docked_windo...
ash/wm/dock/docked_window_layout_manager.cc:1073: const float delta =
(float)available_room /
On 2014/01/06 21:06:53, James Cook wrote:
> nit: static_cast<float>

Done.

[commit-bot: I haz the power, 2014-01-06 21:15:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/101383004/90001

[commit-bot: I haz the power, 2014-01-07 10:07:57]

Change committed as 243236