Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 101383002: Fix unintentional switch case fallthrough. (Closed)

Created:
7 years ago by dmazzoni
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Visibility:
Public.

Description

Fix unintentional switch case fallthrough. I also added a break below, where it's not needed, for clarity, and to avoid any future refactoring from introducing a similar bug. BUG=102485, 177475 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/base/accessibility/accessible_text_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
7 years ago (2013-12-03 08:40:02 UTC) #1
Nico
lgtm, thanks! Is it possible to test this? Can you add 177475 to the BUG= ...
7 years ago (2013-12-03 17:30:39 UTC) #2
dmazzoni
Added bug. I resisted testing this because it was meant to be a naive implementation ...
7 years ago (2013-12-03 17:38:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/101383002/1
7 years ago (2013-12-03 17:38:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/101383002/1
7 years ago (2013-12-03 19:20:36 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-03 21:09:40 UTC) #6
Message was sent while issue was closed.
Change committed as 238455

Powered by Google App Engine
This is Rietveld 408576698