Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1013823005: Remove custom implementation of History.state attribute getter (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, Inactive, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove custom implementation of History.state attribute getter Using [CachedAttribute=stateChanged] gives equivalent generated code, so there is no reason to have a custom implementation. BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192026

Patch Set 1 #

Total comments: 1

Patch Set 2 : adjust test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/custom/V8HistoryCustom.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/frame/History.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Jens Widell
PTAL https://codereview.chromium.org/1013823005/diff/1/Source/bindings/core/v8/custom/V8HistoryCustom.cpp File Source/bindings/core/v8/custom/V8HistoryCustom.cpp (left): https://codereview.chromium.org/1013823005/diff/1/Source/bindings/core/v8/custom/V8HistoryCustom.cpp#oldcode45 Source/bindings/core/v8/custom/V8HistoryCustom.cpp:45: void V8History::stateAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info) For reference, here's the ...
5 years, 9 months ago (2015-03-17 14:51:47 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-17 15:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013823005/1
5 years, 9 months ago (2015-03-17 15:04:42 UTC) #5
Jens Widell
Removing [Custom] caused the state attribute to move to prototype, thus making it show up ...
5 years, 9 months ago (2015-03-17 16:32:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013823005/20001
5 years, 9 months ago (2015-03-17 16:33:06 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:11:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192026

Powered by Google App Engine
This is Rietveld 408576698