Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013803002: SkPaint::FilterLevel -> SkFilterQuality (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
f(malita), reed2
CC:
blink-reviews, danakj, blink-reviews-rendering, dshwang, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, Justin Novosad, jbroman, Dominik Röttsches, blink-layers+watch_chromium.org, dglazkov+blink, Rik, f(malita), jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, Stephen Chennney, aandrey+blink_chromium.org, pdr+graphicswatchlist_chromium.org, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

SkPaint::FilterLevel -> SkFilterQuality precursor to https://codereview.chromium.org/1011683006/ BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191973

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops, fix more call-sites #

Patch Set 3 : I think I caught the last one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -52 lines) Patch
M Source/core/html/HTMLCanvasElement.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContextState.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsTypes.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageBufferSurface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/LoggingCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/LoggingCanvas.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/skia/SkiaUtils.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
reed1
ptal
5 years, 9 months ago (2015-03-16 19:32:49 UTC) #2
reed1
doh, needs recent skia cl to roll in first...
5 years, 9 months ago (2015-03-16 19:39:52 UTC) #3
reed1
needs this https://codereview.chromium.org/1006293003/
5 years, 9 months ago (2015-03-16 19:40:43 UTC) #4
f(malita)
There's also GraphicsTypes:InterpolationQuality I think: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/graphics/GraphicsTypes.h&l=46 https://codereview.chromium.org/1013803002/diff/1/Source/platform/graphics/GraphicsContextState.cpp File Source/platform/graphics/GraphicsContextState.cpp (right): https://codereview.chromium.org/1013803002/diff/1/Source/platform/graphics/GraphicsContextState.cpp#newcode28 Source/platform/graphics/GraphicsContextState.cpp:28: m_strokePaint.setFilterQuality(WebCoreInterpolationQualityToSkFilterQuality(m_interpolationQuality)); Hmm, I ...
5 years, 9 months ago (2015-03-16 19:47:55 UTC) #5
reed1
https://codereview.chromium.org/1013803002/diff/1/Source/platform/graphics/GraphicsContextState.cpp File Source/platform/graphics/GraphicsContextState.cpp (right): https://codereview.chromium.org/1013803002/diff/1/Source/platform/graphics/GraphicsContextState.cpp#newcode28 Source/platform/graphics/GraphicsContextState.cpp:28: m_strokePaint.setFilterQuality(WebCoreInterpolationQualityToSkFilterQuality(m_interpolationQuality)); On 2015/03/16 19:47:55, f(malita) wrote: > Hmm, I ...
5 years, 9 months ago (2015-03-16 21:00:10 UTC) #6
reed2
ptal
5 years, 9 months ago (2015-03-16 23:46:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013803002/40001
5 years, 9 months ago (2015-03-16 23:47:15 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-16 23:47:18 UTC) #12
f(malita)
lgtm good enough for 'em bots, good enough for me :) LGTM
5 years, 9 months ago (2015-03-17 00:12:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013803002/40001
5 years, 9 months ago (2015-03-17 00:12:48 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 03:26:46 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191973

Powered by Google App Engine
This is Rietveld 408576698