Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013753013: Move SkMatrixImageFilter.h into src/core. (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org, robertphillips
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkMatrixImageFilter.h into src/core. Callers in Blink have been updated to call SkImageFilter::CreateMatrixFilter() instead. BUG=skia:3568 Committed: https://skia.googlesource.com/skia/+/8c24d453a214c16d3b2fcb3478a245d14ac7e1a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -65 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
D include/core/SkMatrixImageFilter.h View 1 chunk +0 lines, -65 lines 0 comments Download
A + src/core/SkMatrixImageFilter.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Stephen White
PTAL. Thanks!
5 years, 9 months ago (2015-03-24 14:10:11 UTC) #2
robertphillips
lgtm
5 years, 9 months ago (2015-03-24 14:41:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013753013/1
5 years, 9 months ago (2015-03-24 14:46:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/8c24d453a214c16d3b2fcb3478a245d14ac7e1a9
5 years, 9 months ago (2015-03-24 14:51:36 UTC) #7
reed1
5 years, 9 months ago (2015-03-24 15:37:41 UTC) #8
Message was sent while issue was closed. 
On 2015/03/24 14:51:36, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/8c24d453a214c16d3b2fcb3478a245d14ac7e1a9

sweet!

Powered by Google App Engine
This is Rietveld 408576698