Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1013753009: [DevTools] Do not use constants from Page domain which go away. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not use constants from Page domain which go away. BUG=467059 TBR=pfeldman Committed: https://crrev.com/9e6963d66f0f6caa7e6e5f09ca13c3bfc0818fdb Cr-Commit-Position: refs/heads/master@{#321382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/devtools/protocol/page_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013753009/1
5 years, 9 months ago (2015-03-19 14:35:25 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-19 15:53:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 17:01:45 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 17:02:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e6963d66f0f6caa7e6e5f09ca13c3bfc0818fdb
Cr-Commit-Position: refs/heads/master@{#321382}

Powered by Google App Engine
This is Rietveld 408576698