Issue 1013753009: [DevTools] Do not use constants from Page domain which go away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1013753009: [DevTools] Do not use constants from Page domain which go away. (Closed)

Created:
5 years, 9 months ago by dgozman

Modified:
5 years, 9 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[DevTools] Do not use constants from Page domain which go away. BUG=467059 TBR=pfeldman Committed: https://crrev.com/9e6963d66f0f6caa7e6e5f09ca13c3bfc0818fdb Cr-Commit-Position: refs/heads/master@{#321382}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	content/browser/devtools/protocol/page_handler.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013753009/1

5 years, 9 months ago (2015-03-19 14:35:25 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-19 17:02:14 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9e6963d66f0f6caa7e6e5f09ca13c3bfc0818fdb
Cr-Commit-Position: refs/heads/master@{#321382}