Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1013743006: [turbofan][arm64] Match fneg for -0.0 - x pattern. (Closed)

Created:
5 years, 9 months ago by baptiste.afsa1
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan][arm64] Match fneg for -0.0 - x pattern. Note that this patch add an extra bit to the ArchOpcodeField. R=bmeurer@chromium.org Committed: https://crrev.com/fe7441225100660d01e66ce3bcaefe368f62df81 Cr-Commit-Position: refs/heads/master@{#27494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
baptiste.afsa1
PTAL
5 years, 9 months ago (2015-03-26 16:27:36 UTC) #1
Benedikt Meurer
Nice, thanks. LGTM
5 years, 9 months ago (2015-03-27 08:02:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013743006/1
5 years, 9 months ago (2015-03-27 08:03:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 08:32:24 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fe7441225100660d01e66ce3bcaefe368f62df81 Cr-Commit-Position: refs/heads/master@{#27494}
5 years, 9 months ago (2015-03-27 08:32:39 UTC) #6
Yang
5 years, 9 months ago (2015-03-27 09:11:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1041633002/ by yangguo@chromium.org.

The reason for reverting is: Revert due to crash..

Powered by Google App Engine
This is Rietveld 408576698