Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: sky/framework/components/material.dart

Issue 1013713005: Cleanup events related to material splashes (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/framework/components/material.dart
diff --git a/sky/framework/components/material.dart b/sky/framework/components/material.dart
index 8b6177938ce9dc920b2d6889208535ae1032d133..fd1941160af65cbaa41fa4f1bd752c69ca99bd5f 100644
--- a/sky/framework/components/material.dart
+++ b/sky/framework/components/material.dart
@@ -9,15 +9,6 @@ import 'dart:sky' as sky;
import 'ink_splash.dart';
class Material extends Component {
- static final Style _splashesStyle = new Style('''
- transform: translateX(0);
- position: absolute;
- top: 0;
- left: 0;
- right: 0;
- bottom: 0'''
- );
-
static final List<Style> shadowStyle = [
null,
new Style('box-shadow: ${Shadow[1]}'),
@@ -49,23 +40,17 @@ class Material extends Component {
List<Node> childrenIncludingSplashes = [];
if (_splashes != null) {
- childrenIncludingSplashes.add(new Container(
- style: _splashesStyle,
- children: new List.from(_splashes.map(
- (s) => new InkSplash(s.onStyleChanged))),
- key: 'Splashes'
- ));
+ childrenIncludingSplashes.addAll(
+ _splashes.map((s) => new InkSplash(s.onStyleChanged)));
}
if (children != null)
childrenIncludingSplashes.addAll(children);
return new Container(
- key: 'Material',
style: level > 0 ? style.extend(shadowStyle[level]) : style,
inlineStyle: inlineStyle,
- children: childrenIncludingSplashes
- );
+ children: childrenIncludingSplashes);
}
sky.ClientRect _getBoundingRect() => (getRoot() as sky.Element).getBoundingClientRect();

Powered by Google App Engine
This is Rietveld 408576698