sky/framework/components/checkbox.dart - Issue 1013713005: Cleanup events related to material splashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/framework/components/checkbox.dart

Issue 1013713005: Cleanup events related to material splashes (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/framework/components/checkbox.dart

diff --git a/sky/framework/components/checkbox.dart b/sky/framework/components/checkbox.dart

index bc7e14a2bede5f9e4d04836443e31b74b5ef5be6..8a0d325b11ebe40a6fbda2b7d1e77902e838af82 100644

--- a/sky/framework/components/checkbox.dart

+++ b/sky/framework/components/checkbox.dart

@@ -59,7 +59,7 @@ class Checkbox extends ButtonBase {

ValueChanged onChanged;

Checkbox({ Object key, this.onChanged, this.checked }) : super(key: key) {

- events.listen('click', _handleClick);

+ events.listen('gesturetap', _handleClick);

eseidel 2015/03/16 23:21:25 Should events.listen assert/log for any name it do

abarth-chromium 2015/03/16 23:22:55 Oh, click is a real event in our system currently.

}

void _handleClick(sky.Event e) {

« no previous file with comments | « sky/examples/stocks-fn/stocksapp.dart ('k') | sky/framework/components/drawer.dart » ('j') | no next file with comments »