Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1013713005: Cleanup events related to material splashes (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Cleanup events related to material splashes This CL is a warmup for using a more sophisticated gesture disambiguation. 1) Use gesturetap instead of click. We should probably remove click events because folks should use gesturetap to integrate with the gesture system. 2) Handle the case where you swipe the drawer during an animation. Previously we had an assert which triggered in some multitouch scenarios. We'll eventually move this over to gestureswipe. 3) Remove an extra container for ink splashes. There's no need to group all the ink splashes in a container. They can all just be children of the Material component itself. This structure is left over from when Material was a base class. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3df236b69420f63891b9dcd2891fcaa897f98320

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -34 lines) Patch
M sky/examples/stocks-fn/stocksapp.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/components/checkbox.dart View 1 chunk +1 line, -1 line 2 comments Download
M sky/framework/components/drawer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/framework/components/ink_splash.dart View 2 chunks +4 lines, -11 lines 0 comments Download
M sky/framework/components/material.dart View 2 chunks +3 lines, -18 lines 0 comments Download
M sky/framework/components/radio.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-16 23:08:15 UTC) #1
eseidel
https://codereview.chromium.org/1013713005/diff/1/sky/framework/components/checkbox.dart File sky/framework/components/checkbox.dart (right): https://codereview.chromium.org/1013713005/diff/1/sky/framework/components/checkbox.dart#newcode62 sky/framework/components/checkbox.dart:62: events.listen('gesturetap', _handleClick); Should events.listen assert/log for any name it ...
5 years, 9 months ago (2015-03-16 23:21:26 UTC) #2
abarth-chromium
https://codereview.chromium.org/1013713005/diff/1/sky/framework/components/checkbox.dart File sky/framework/components/checkbox.dart (right): https://codereview.chromium.org/1013713005/diff/1/sky/framework/components/checkbox.dart#newcode62 sky/framework/components/checkbox.dart:62: events.listen('gesturetap', _handleClick); On 2015/03/16 at 23:21:25, eseidel wrote: > ...
5 years, 9 months ago (2015-03-16 23:22:55 UTC) #3
eseidel
lgtm
5 years, 9 months ago (2015-03-16 23:59:30 UTC) #4
abarth-chromium
5 years, 9 months ago (2015-03-17 03:54:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3df236b69420f63891b9dcd2891fcaa897f98320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698