chrome/browser/resources/options/cookies_list.js - Issue 1013683002: Fix for Back navigation keyboard shortcut does not work properly for chrome://settings/cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/cookies_list.js

Issue 1013683002: Fix for Back navigation keyboard shortcut does not work properly for chrome://settings/cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/cookies_list.js

diff --git a/chrome/browser/resources/options/cookies_list.js b/chrome/browser/resources/options/cookies_list.js

index 767b5a9530b2d1ae34614d47fd0d80864eb918ad..550fb637cad2088fd1eb391909af550c47d6b51e 100644

--- a/chrome/browser/resources/options/cookies_list.js

+++ b/chrome/browser/resources/options/cookies_list.js

@@ -734,7 +734,8 @@ cr.define('options', function() {

handleKeyLeftRight_: function(e) {

Dan Beam 2015/03/16 21:16:20 nit: do this instead if (e.altKey || e.ctrlKey ||

var id = e.keyIdentifier;

- if ((id == 'Left' || id == 'Right') && this.expandedItem) {

+ if (!e.altKey && !e.ctrlKey && !e.metaKey && !e.shiftKey &&

+ (id == 'Left' || id == 'Right') && this.expandedItem) {

var cs = this.ownerDocument.defaultView.getComputedStyle(this);

var rtl = cs.direction == 'rtl';

if ((!rtl && id == 'Left') || (rtl && id == 'Right'))

« no previous file with comments | « no previous file | no next file » | no next file with comments »