Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1013683002: Fix for Back navigation keyboard shortcut does not work properly for chrome://settings/cookies. (Closed)

Created:
5 years, 9 months ago by Deepak
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for Back navigation keyboard shortcut does not work properly for chrome://settings/cookies. Earlier left and right navigation key's are getting used without check for modifiers. Check added for alt,ctrl,meta,shift key, when we have modifer then default handling will happen that will move it to previous url with alt+left arrow, and when we have just left or right arrow keys then cookies list specific handling will happen. BUG=467476 Committed: https://crrev.com/9c2d1afc6031dd54e54f75244438dd4aab8f78b8 Cr-Commit-Position: refs/heads/master@{#320872}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/options/cookies_list.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Deepak
PTAL Thanks.
5 years, 9 months ago (2015-03-16 13:40:54 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1013683002/diff/1/chrome/browser/resources/options/cookies_list.js File chrome/browser/resources/options/cookies_list.js (right): https://codereview.chromium.org/1013683002/diff/1/chrome/browser/resources/options/cookies_list.js#newcode735 chrome/browser/resources/options/cookies_list.js:735: handleKeyLeftRight_: function(e) { nit: do this instead if ...
5 years, 9 months ago (2015-03-16 21:16:20 UTC) #3
Deepak
On 2015/03/16 21:16:20, Dan Beam wrote: > lgtm > > https://codereview.chromium.org/1013683002/diff/1/chrome/browser/resources/options/cookies_list.js > File chrome/browser/resources/options/cookies_list.js (right): ...
5 years, 9 months ago (2015-03-17 02:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013683002/20001
5 years, 9 months ago (2015-03-17 02:46:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 05:47:18 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 05:48:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c2d1afc6031dd54e54f75244438dd4aab8f78b8
Cr-Commit-Position: refs/heads/master@{#320872}

Powered by Google App Engine
This is Rietveld 408576698