Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1013663002: Revert of Revert of Add WebSocketDispatcherHostTest.InvalidScheme (Closed)

Created:
5 years, 9 months ago by hiroshige
Modified:
5 years, 9 months ago
Reviewers:
Adam Rice
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #1 id:1 of https://codereview.chromium.org/1007263002/) Reason for revert: The breakage still persists https://crbug.com/467471 after the original CL was reverted. Original issue's description: > Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #3 id:40001 of https://codereview.chromium.org/1000883004/) > > Reason for revert: > Speculatively revert for https://crbug.com/467471 > > Original issue's description: > > Add WebSocketDispatcherHostTest.InvalidScheme > > > > This is a regression test for > > https://codereview.chromium.org/998173003/. > > > > BUG=466335 > > > > Committed: https://crrev.com/6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871 > > Cr-Commit-Position: refs/heads/master@{#320262} > > TBR=ricea@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=466335 > > Committed: https://crrev.com/725e3aed98c2b8a22c17bfef078b9c7a20709e49 > Cr-Commit-Position: refs/heads/master@{#320704} TBR=ricea@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466335 Committed: https://crrev.com/3022a392dd9af3ffd8a55e67c688e80f904dfc37 Cr-Commit-Position: refs/heads/master@{#320717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/browser/renderer_host/websocket_dispatcher_host_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hiroshige
Created Revert of Revert of Add WebSocketDispatcherHostTest.InvalidScheme
5 years, 9 months ago (2015-03-16 12:57:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013663002/1
5 years, 9 months ago (2015-03-16 12:57:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 12:58:19 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 12:58:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3022a392dd9af3ffd8a55e67c688e80f904dfc37
Cr-Commit-Position: refs/heads/master@{#320717}

Powered by Google App Engine
This is Rietveld 408576698