Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1013653002: Use Courier New for Arabic monospace text on Windows (Closed)

Created:
5 years, 9 months ago by ebraminio
Modified:
5 years, 9 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Courier New for Arabic monospace text on Windows Before DirectWrite, default monospace font was Courier New but while adding support for DirectWrite, it is switched to Consolas which lacks Arabic glyphs. This is to improve the situation. BUG=466754 Committed: https://crrev.com/0da2f92e4ed982ad40839560be1a24e47c849bee Cr-Commit-Position: refs/heads/master@{#321446}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/app/resources/locale_settings_win.grd View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ebraminio
Just like https://codereview.chromium.org/663363004 PTAL
5 years, 9 months ago (2015-03-16 12:28:29 UTC) #2
behdad_google
lgtm
5 years, 9 months ago (2015-03-16 18:35:43 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm but we need eae@ before landing this.
5 years, 9 months ago (2015-03-16 19:51:20 UTC) #5
eae
LGTM
5 years, 9 months ago (2015-03-19 20:47:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013653002/40001
5 years, 9 months ago (2015-03-19 20:47:55 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 22:10:29 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:11:10 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0da2f92e4ed982ad40839560be1a24e47c849bee
Cr-Commit-Position: refs/heads/master@{#321446}

Powered by Google App Engine
This is Rietveld 408576698