remoting.Identity unit-tests and fixes.

remoting/webapp/crd/js/identity.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Wrapper class for Chrome's identity API.
  */
 /** @suppress {duplicate} */
 var remoting = remoting || {};
@@ skipping 170 matching lines @@
   }
 
   // If not, pass an error back to the callback(s) if we've already prompted the
   // user for permission.
   if (this.interactive_) {
     var error_message =
         chrome.runtime.lastError ? chrome.runtime.lastError.message
                                  : 'Unknown error.';
     console.error(error_message);
     var error = (error_message == USER_CANCELLED) ?
-        remoting.Error.Tag.CANCELLED : remoting.Error.Tag.NOT_AUTHENTICATED;
+        new remoting.Error(remoting.Error.Tag.CANCELLED) :
+        new remoting.Error(remoting.Error.Tag.NOT_AUTHENTICATED);

[Jamie, 2015/03/16 22:52:15]

getToken is documented as passing a remoting.Error on reject.

     authTokenDeferred.reject(error);
     this.authTokenDeferred_ = null;
     return;
   }
 
   // If there's no token, but we haven't yet prompted for permission, do so
   // now.
   var that = this;
   var showConsentDialog =
       (this.consentDialog_) ? this.consentDialog_.show() : Promise.resolve();
   showConsentDialog.then(function() {
     that.interactive_ = true;
     chrome.identity.getAuthToken({'interactive': that.interactive_},
                                  that.onAuthComplete_.bind(that));
   });
 };
 
 /**
  * Returns whether the web app has authenticated with the Google services.
  *
  * @return {boolean}
  */
 remoting.Identity.prototype.isAuthenticated = function() {
   return remoting.identity.email_ !== '';
 };
 
 })();