Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013633003: remoting.Identity unit-tests and fixes. (Closed)

Created:
5 years, 9 months ago by Jamie
Modified:
5 years, 9 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remoting.Identity unit-tests and fixes. Committed: https://crrev.com/2119652d7e45dd0787143b5ec39703b50bbdc96b Cr-Commit-Position: refs/heads/master@{#320844}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix jscompile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -8 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/base/js/base_event_hook_unittest.js View 1 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/webapp/crd/js/identity.js View 1 chunk +2 lines, -1 line 0 comments Download
A remoting/webapp/crd/js/identity_unittest.js View 1 1 chunk +102 lines, -0 lines 0 comments Download
M remoting/webapp/js_proto/chrome_mocks.js View 1 2 chunks +37 lines, -1 line 0 comments Download
M remoting/webapp/js_proto/sinon_proto.js View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jamie
ptal https://codereview.chromium.org/1013633003/diff/1/remoting/webapp/crd/js/identity.js File remoting/webapp/crd/js/identity.js (right): https://codereview.chromium.org/1013633003/diff/1/remoting/webapp/crd/js/identity.js#newcode192 remoting/webapp/crd/js/identity.js:192: new remoting.Error(remoting.Error.Tag.NOT_AUTHENTICATED); getToken is documented as passing a ...
5 years, 9 months ago (2015-03-16 22:52:15 UTC) #2
kelvinp
lgtm
5 years, 9 months ago (2015-03-16 23:28:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013633003/1
5 years, 9 months ago (2015-03-16 23:30:41 UTC) #5
Jamie
FYI
5 years, 9 months ago (2015-03-17 00:04:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013633003/20001
5 years, 9 months ago (2015-03-17 00:04:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 02:04:42 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 02:05:19 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2119652d7e45dd0787143b5ec39703b50bbdc96b
Cr-Commit-Position: refs/heads/master@{#320844}

Powered by Google App Engine
This is Rietveld 408576698