Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4623)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 101363002: Turn on deprecation warnings for V8 on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 8acff21a20e521a7aa3fdffbd0fb1bd10a28e96b..1f886f5b45a399c2128249dd13c67d63b427934e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1997,12 +1997,11 @@
# Set this to use the new DX11 version of ANGLE.
# TODO(apatrick): Remove this when the transition is complete.
'ANGLE_DX11',
+
+ # Don't use deprecated V8 APIs anywhere.
+ 'V8_DEPRECATION_WARNINGS',
],
'conditions': [
- # TODO(jochen): Enable this unconditionally.
- ['OS!="mac"', {
- 'defines': ['V8_DEPRECATION_WARNINGS'],
- }],
['(OS=="mac" or OS=="ios") and asan==1', {
'dependencies': [
'<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698