Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013613002: Three dot menu is shown now on WebView start screen. (Closed)

Created:
5 years, 9 months ago by merkulova
Modified:
5 years, 9 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Three dot menu is shown now on WebView start screen. BUG=465863 TBR=noms@chromium.org, cpu@chromium.org Committed: https://crrev.com/4b6d498784f5b94ed38f2ee5446d9f35b5865062 Cr-Commit-Position: refs/heads/master@{#320710}

Patch Set 1 #

Patch Set 2 : Button used instead of div for 'Add SU user'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.css View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.html View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.js View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
merkulova
5 years, 9 months ago (2015-03-16 08:59:04 UTC) #2
merkulova
5 years, 9 months ago (2015-03-16 09:40:50 UTC) #3
Dmitry Polukhin
lgtm
5 years, 9 months ago (2015-03-16 10:25:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013613002/20001
5 years, 9 months ago (2015-03-16 10:46:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 12:07:02 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 12:08:05 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4b6d498784f5b94ed38f2ee5446d9f35b5865062
Cr-Commit-Position: refs/heads/master@{#320710}

Powered by Google App Engine
This is Rietveld 408576698