Issue 1013583002: Make the SentPacketManager remove pending retransmissions for reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1013583002: Make the SentPacketManager remove pending retransmissions for reset (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Replace_CID_with_connection_id_88463135

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make the SentPacketManager remove pending retransmissions for reset streams. No behavior change yet. That will be in a flag protected followup. Minor change to linked_hash_map's erase method to return an iterator pointing to the new location of the element that followed the last element erased by the function call (ala internal source code and std:: c++). Merge internal change: 88507368 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -16 lines)			Patch
M	net/base/linked_hash_map.h	View	1 chunk	+13 lines, -8 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	3 chunks	+28 lines, -3 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_unacked_packet_map_test.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages