Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: net/quic/quic_connection_test.cc

Issue 1013573002: Only changes comments. Replace "CID" with "connection id" in various (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Provide_MockConnection_constructor_88461470
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 31ea1a6f4d78b24593fb8ddfab1a0793f85723ee..2eed176c01e83dccab36a20f7f48975d92e8cacb 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -3224,10 +3224,10 @@ TEST_P(QuicConnectionTest, LoopThroughSendingPacketsWithTruncation) {
connection_.SendStreamDataWithString(
3, payload, 0, !kFin, nullptr).bytes_consumed);
// Track the size of the second packet here. The overhead will be the largest
- // we see in this test, due to the non-truncated CID.
+ // we see in this test, due to the non-truncated connection id.
size_t non_truncated_packet_size = writer_->last_packet_size();
- // Change to a 4 byte CID.
+ // Change to a 4 byte connection id.
QuicConfig config;
QuicConfigPeer::SetReceivedBytesForConnectionId(&config, 4);
connection_.SetFromConfig(config);
@@ -3240,8 +3240,7 @@ TEST_P(QuicConnectionTest, LoopThroughSendingPacketsWithTruncation) {
// headers here are also 4 byte smaller.
EXPECT_EQ(non_truncated_packet_size, writer_->last_packet_size() + 8);
-
- // Change to a 1 byte CID.
+ // Change to a 1 byte connection id.
QuicConfigPeer::SetReceivedBytesForConnectionId(&config, 1);
connection_.SetFromConfig(config);
EXPECT_CALL(*send_algorithm_, OnPacketSent(_, _, _, _, _)).Times(2);
@@ -3251,7 +3250,7 @@ TEST_P(QuicConnectionTest, LoopThroughSendingPacketsWithTruncation) {
// Just like above, we save 7 bytes on payload, and 7 on truncation.
EXPECT_EQ(non_truncated_packet_size, writer_->last_packet_size() + 7 * 2);
- // Change to a 0 byte CID.
+ // Change to a 0 byte connection id.
QuicConfigPeer::SetReceivedBytesForConnectionId(&config, 0);
connection_.SetFromConfig(config);
EXPECT_CALL(*send_algorithm_, OnPacketSent(_, _, _, _, _)).Times(2);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698