Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: ui/gfx/render_text.cc

Issue 1013543006: [RenderText] Adding vertical alignment options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index c3a4f00e0fd14524e3ad0247c4efb3085a34ee1d..6aa490e4c076a770529b0576b8095e4b1dcb8052 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -484,6 +484,14 @@ void RenderText::SetHorizontalAlignment(HorizontalAlignment alignment) {
}
}
+void RenderText::SetVerticalAlignment(VerticalAlignment alignment) {
+ if (vertical_alignment_ != alignment) {
+ vertical_alignment_ = alignment;
+ display_offset_ = Vector2d();
+ cached_bounds_and_offset_valid_ = false;
+ }
+}
+
void RenderText::SetFontList(const FontList& font_list) {
font_list_ = font_list;
const int font_style = font_list.GetFontStyle();
@@ -955,6 +963,7 @@ Vector2d RenderText::GetLineOffset(size_t line_number) {
RenderText::RenderText()
: horizontal_alignment_(base::i18n::IsRTL() ? ALIGN_RIGHT : ALIGN_LEFT),
+ vertical_alignment_(VALIGN_MIDDLE),
directionality_mode_(DIRECTIONALITY_FROM_TEXT),
text_direction_(base::i18n::UNKNOWN_DIRECTION),
cursor_enabled_(true),
@@ -1155,15 +1164,28 @@ Vector2d RenderText::GetAlignmentOffset(size_t line_number) {
offset.set_x((offset.x() + 1) / 2);
}
- // Vertically center the text.
+ // Vertically align the text.
if (multiline_) {
dschuyler 2015/03/24 23:56:53 This hasn't been tested on Windows yet. Do these
- const int text_height = lines_.back().preceding_heights +
- lines_.back().size.height();
- offset.set_y((display_rect_.height() - text_height) / 2);
+ const int text_height =
+ lines_.back().preceding_heights + lines_.back().size.height();
+ if (vertical_alignment_ == VALIGN_TOP) {
+ offset.set_y(lines_.back().preceding_heights);
+ } else if (vertical_alignment_ == VALIGN_BOTTOM) {
+ offset.set_y(display_rect_.height() - text_height);
+ } else {
+ // Vertically center the text.
+ offset.set_y((display_rect_.height() - text_height) / 2);
+ }
} else {
- offset.set_y(GetBaseline() - GetDisplayTextBaseline());
+ if (vertical_alignment_ == VALIGN_TOP) {
+ offset.set_y(0);
+ } else if (vertical_alignment_ == VALIGN_BOTTOM) {
+ offset.set_y(display_rect_.height() - font_list_.GetHeight());
+ } else {
+ // Vertically center the text.
+ offset.set_y(GetBaseline() - GetDisplayTextBaseline());
+ }
}
-
return offset;
}
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698