[RenderText] Adding vertical alignment options

ui/gfx/text_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_TEXT_CONSTANTS_H_
 #define UI_GFX_TEXT_CONSTANTS_H_
 
 namespace gfx {
 
 // TODO(msw): Distinguish between logical character stops and glyph stops?
 // TODO(msw): Merge with base::i18n::BreakIterator::BreakType.
 enum BreakType {
   CHARACTER_BREAK = 0, // Stop cursor movement on neighboring characters.
   WORD_BREAK,          // Stop cursor movement on nearest word boundaries.
   LINE_BREAK,          // Stop cursor movement on line ends as shown on screen.
 };
 
 // Horizontal text alignment modes.
 enum HorizontalAlignment {
   ALIGN_LEFT = 0, // Align the text's left edge with that of its display area.
   ALIGN_CENTER,   // Align the text's center with that of its display area.
   ALIGN_RIGHT,    // Align the text's right edge with that of its display area.
   ALIGN_TO_HEAD,  // Align the text to its first strong character's direction.
 };
 
+// Vertical text alignment modes.
+enum VerticalAlignment {
+  VALIGN_TOP = 0,  // Align the text's top edge with that of its display area.

[msw, 2015/03/30 19:19:12]

nit: one fewer space before the comments on this line and the next line.

[dschuyler, 2015/03/31 18:38:14]

git cl format insists on adding the spaces back.  Should I let cl format win or
try to force the spacing?

[msw, 2015/04/01 15:07:17]

I'd force the spacing tighter (like many other enums here), or optionally
shorten the 1st and 3rd comment by removing the word 'edge', so the bottom
comment can be aligned with the top two.

+  VALIGN_MIDDLE,   // Align the text's middle with that of its display area.
+  VALIGN_BOTTOM,  // Align the text's bottom edge with that of its display area.
+};
+
 // The directionality modes used to determine the base text direction.
 enum DirectionalityMode {
   DIRECTIONALITY_FROM_TEXT = 0, // Use the first strong character's direction.
   DIRECTIONALITY_FROM_UI,       // Use the UI locale's text reading direction.
   DIRECTIONALITY_FORCE_LTR,     // Use LTR regardless of content or UI locale.
   DIRECTIONALITY_FORCE_RTL,     // Use RTL regardless of content or UI locale.
 };
 
 // Text styles and adornments.
 // TODO(msw): Merge with gfx::Font::FontStyle.
@@ skipping 32 matching lines @@
   ELIDE_HEAD,   // Add an ellipsis at the start of the string.
   ELIDE_MIDDLE, // Add an ellipsis in the middle of the string.
   ELIDE_TAIL,   // Add an ellipsis at the end of the string.
   ELIDE_EMAIL,  // Add ellipses to username and domain substrings.
   FADE_TAIL,    // Fade the string's end opposite of its horizontal alignment.
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_TEXT_CONSTANTS_H_