Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1013543004: X87: Remove PropertyCell space (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove PropertyCell space port 16c8485a35efc36cf6ccd15185282d65412e1502 (r27269). original commit message: Replaces StoreGlobalCell / LoadGlobalCell with NamedField variants that use write barriers. BUG= Committed: https://crrev.com/62c546517f6c821bcf09169eaec160d9c73da83d Cr-Commit-Position: refs/heads/master@{#27395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M src/x87/lithium-codegen-x87.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/x87/lithium-x87.h View 4 chunks +0 lines, -22 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-24 09:44:50 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-24 09:47:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013543004/1
5 years, 9 months ago (2015-03-24 09:47:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 10:10:53 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 10:11:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62c546517f6c821bcf09169eaec160d9c73da83d
Cr-Commit-Position: refs/heads/master@{#27395}

Powered by Google App Engine
This is Rietveld 408576698