Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1013533002: content: Use at most 128MB of discardable memory on Android. (Closed)

Created:
5 years, 9 months ago by reveman
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Use at most 128MB of discardable memory on Android. 512MB is needed on desktop to not regress performance on some important benchmarks but this limit is much more than needed on Android. By reducing it to 128MB we can also avoid using a different allocation size on Android. This makes the discardable memory behavior more consistent across platforms and improves the browser's ability to purge memory on Android. This change also reduces the amount of discardable memory used on low end devices to 1/8th of the normal limit. BUG=489174 Committed: https://crrev.com/df13fe318df46dc9955762da26c473e1d5f0e0ac Cr-Commit-Position: refs/heads/master@{#330754}

Patch Set 1 #

Patch Set 2 : include low-end device tuning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M content/child/child_discardable_shared_memory_manager.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
5 years, 7 months ago (2015-05-20 15:09:51 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-20 16:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013533002/20001
5 years, 7 months ago (2015-05-20 16:53:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 16:57:38 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:00:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df13fe318df46dc9955762da26c473e1d5f0e0ac
Cr-Commit-Position: refs/heads/master@{#330754}

Powered by Google App Engine
This is Rietveld 408576698