Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 101353002: Files.app: Don't pass {singleton: false} to chrome.app.window.create. (Closed)

Created:
7 years ago by kinaba
Modified:
7 years ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Don't pass {singleton: false} to chrome.app.window.create. It's deprecated in r233176 and the option is the current default. BUG=231166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238417

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/resources/file_manager/background/js/background.js View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
7 years ago (2013-12-03 08:34:04 UTC) #1
yoshiki
lgtm
7 years ago (2013-12-03 15:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/101353002/20001
7 years ago (2013-12-03 15:35:29 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-03 17:09:02 UTC) #4
Message was sent while issue was closed.
Change committed as 238417

Powered by Google App Engine
This is Rietveld 408576698