Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1013463004: NTP checks for guest sessions before updating the login bar. (Closed)

Created:
5 years, 9 months ago by Mike Lerman
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP checks for guest sessions before updating the login bar. BUG=463038 Committed: https://crrev.com/55389ef3e45ec11f5dbb12763899cd1ada4cfe48 Cr-Commit-Position: refs/heads/master@{#321222}

Patch Set 1 #

Total comments: 2

Patch Set 2 : check signin_manager for null directly #

Patch Set 3 : Because ChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Mike Lerman
Hi Dan, Adding some null-safety to a section of the NTP code for a crash. ...
5 years, 9 months ago (2015-03-17 20:03:41 UTC) #2
Dan Beam
where's the actual crash? which dereference?
5 years, 9 months ago (2015-03-17 22:25:56 UTC) #3
Mike Lerman
On 2015/03/17 22:25:56, Dan Beam wrote: > where's the actual crash? which dereference? SigninManagerFactory::GetForProfile(profile) returns ...
5 years, 9 months ago (2015-03-18 12:25:10 UTC) #4
Dan Beam
https://codereview.chromium.org/1013463004/diff/1/chrome/browser/ui/webui/ntp/ntp_login_handler.cc File chrome/browser/ui/webui/ntp/ntp_login_handler.cc (right): https://codereview.chromium.org/1013463004/diff/1/chrome/browser/ui/webui/ntp/ntp_login_handler.cc#newcode180 chrome/browser/ui/webui/ntp/ntp_login_handler.cc:180: SigninManagerFactory::GetForProfile(profile)->GetAuthenticatedUsername(); auto* factory = SigninManagerFactory::GetForProfile(profile); if (!factory) { // ...
5 years, 9 months ago (2015-03-18 17:08:09 UTC) #5
Mike Lerman
https://codereview.chromium.org/1013463004/diff/1/chrome/browser/ui/webui/ntp/ntp_login_handler.cc File chrome/browser/ui/webui/ntp/ntp_login_handler.cc (right): https://codereview.chromium.org/1013463004/diff/1/chrome/browser/ui/webui/ntp/ntp_login_handler.cc#newcode180 chrome/browser/ui/webui/ntp/ntp_login_handler.cc:180: SigninManagerFactory::GetForProfile(profile)->GetAuthenticatedUsername(); On 2015/03/18 17:08:09, Dan Beam wrote: > auto* ...
5 years, 9 months ago (2015-03-18 19:23:47 UTC) #6
Dan Beam
lgtm
5 years, 9 months ago (2015-03-18 21:33:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013463004/40001
5 years, 9 months ago (2015-03-18 21:37:01 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-18 22:38:53 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 22:40:08 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/55389ef3e45ec11f5dbb12763899cd1ada4cfe48
Cr-Commit-Position: refs/heads/master@{#321222}

Powered by Google App Engine
This is Rietveld 408576698