base/ios/weak_nsobject.h - Issue 1013463003: Update from https://crrev.com/320931

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/ios/weak_nsobject.h

Issue 1013463003: Update from https://crrev.com/320931 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/ios/weak_nsobject.h

diff --git a/base/ios/weak_nsobject.h b/base/ios/weak_nsobject.h

index a1984bb91824dbc886570d43363b1d9162a3b939..fc3a7c38dc4ab5b195bdc9669d5ff50bc1095e7f 100644

--- a/base/ios/weak_nsobject.h

+++ b/base/ios/weak_nsobject.h

@@ -117,7 +117,9 @@ class WeakNSProtocol {

}

WeakNSProtocol& operator=(const WeakNSProtocol<NST>& that) {

- DCHECK(checker_.CalledOnValidThread());

+ // A WeakNSProtocol object can be copied on one thread and used on

+ // another.

+ checker_.DetachFromThread();

container_ = that.container_;

return *this;

}

« no previous file with comments | « base/files/file_posix.cc ('k') | base/ios/weak_nsobject_unittest.mm » ('j') | no next file with comments »