Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Side by Side Diff: mojo/tools/roll/cc_strip_video.patch

Issue 1013463003: Update from https://crrev.com/320931 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/perftests/texture_upload_perftest.cc ('k') | sandbox/linux/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 diff --git a/cc/BUILD.gn b/cc/BUILD.gn 1 diff --git a/cc/BUILD.gn b/cc/BUILD.gn
2 index 0411b45..4ee07db 100644 2 index bd8bfdd..6e55656 100644
3 --- a/cc/BUILD.gn 3 --- a/cc/BUILD.gn
4 +++ b/cc/BUILD.gn 4 +++ b/cc/BUILD.gn
5 @@ -222,13 +222,6 @@ component("cc") { 5 @@ -189,13 +189,6 @@ component("cc") {
6 "layers/ui_resource_layer.h", 6 "layers/ui_resource_layer.h",
7 "layers/ui_resource_layer_impl.cc", 7 "layers/ui_resource_layer_impl.cc",
8 "layers/ui_resource_layer_impl.h", 8 "layers/ui_resource_layer_impl.h",
9 - "layers/video_frame_provider.h", 9 - "layers/video_frame_provider.h",
10 - "layers/video_frame_provider_client_impl.cc", 10 - "layers/video_frame_provider_client_impl.cc",
11 - "layers/video_frame_provider_client_impl.h", 11 - "layers/video_frame_provider_client_impl.h",
12 - "layers/video_layer.cc", 12 - "layers/video_layer.cc",
13 - "layers/video_layer.h", 13 - "layers/video_layer.h",
14 - "layers/video_layer_impl.cc", 14 - "layers/video_layer_impl.cc",
15 - "layers/video_layer_impl.h", 15 - "layers/video_layer_impl.h",
16 "output/begin_frame_args.cc", 16 "output/begin_frame_args.cc",
17 "output/begin_frame_args.h", 17 "output/begin_frame_args.h",
18 "output/bsp_tree.cc", 18 "output/bsp_tree.cc",
19 @@ -486,8 +479,6 @@ component("cc") { 19 @@ -458,8 +451,6 @@ component("cc") {
20 "resources/ui_resource_client.h", 20 "resources/ui_resource_client.h",
21 "resources/ui_resource_request.cc", 21 "resources/ui_resource_request.cc",
22 "resources/ui_resource_request.h", 22 "resources/ui_resource_request.h",
23 - "resources/video_resource_updater.cc", 23 - "resources/video_resource_updater.cc",
24 - "resources/video_resource_updater.h", 24 - "resources/video_resource_updater.h",
25 "resources/zero_copy_tile_task_worker_pool.cc", 25 "resources/zero_copy_tile_task_worker_pool.cc",
26 "resources/zero_copy_tile_task_worker_pool.h", 26 "resources/zero_copy_tile_task_worker_pool.h",
27 "scheduler/begin_frame_source.cc", 27 "scheduler/begin_frame_source.cc",
28 @@ -628,8 +619,6 @@ source_set("test_support") { 28 @@ -606,8 +597,6 @@ source_set("test_support") {
29 "test/fake_tile_manager_client.h", 29 "test/fake_tile_manager_client.h",
30 "test/fake_ui_resource_layer_tree_host_impl.cc", 30 "test/fake_ui_resource_layer_tree_host_impl.cc",
31 "test/fake_ui_resource_layer_tree_host_impl.h", 31 "test/fake_ui_resource_layer_tree_host_impl.h",
32 - "test/fake_video_frame_provider.cc", 32 - "test/fake_video_frame_provider.cc",
33 - "test/fake_video_frame_provider.h", 33 - "test/fake_video_frame_provider.h",
34 "test/geometry_test_utils.cc", 34 "test/geometry_test_utils.cc",
35 "test/geometry_test_utils.h", 35 "test/geometry_test_utils.h",
36 "test/impl_side_painting_settings.h", 36 "test/impl_side_painting_settings.h",
37 @@ -787,7 +776,6 @@ test("cc_unittests") { 37 @@ -766,7 +755,6 @@ test("cc_unittests") {
38 "layers/tiled_layer_unittest.cc", 38 "layers/tiled_layer_unittest.cc",
39 "layers/ui_resource_layer_impl_unittest.cc", 39 "layers/ui_resource_layer_impl_unittest.cc",
40 "layers/ui_resource_layer_unittest.cc", 40 "layers/ui_resource_layer_unittest.cc",
41 - "layers/video_layer_impl_unittest.cc", 41 - "layers/video_layer_impl_unittest.cc",
42 "output/begin_frame_args_unittest.cc", 42 "output/begin_frame_args_unittest.cc",
43 "output/delegating_renderer_unittest.cc", 43 "output/delegating_renderer_unittest.cc",
44 "output/filter_operations_unittest.cc", 44 "output/filter_operations_unittest.cc",
45 @@ -848,7 +836,6 @@ test("cc_unittests") { 45 @@ -827,7 +815,6 @@ test("cc_unittests") {
46 "trees/layer_tree_host_unittest_picture.cc", 46 "trees/layer_tree_host_unittest_picture.cc",
47 "trees/layer_tree_host_unittest_proxy.cc", 47 "trees/layer_tree_host_unittest_proxy.cc",
48 "trees/layer_tree_host_unittest_scroll.cc", 48 "trees/layer_tree_host_unittest_scroll.cc",
49 - "trees/layer_tree_host_unittest_video.cc", 49 - "trees/layer_tree_host_unittest_video.cc",
50 "trees/layer_tree_impl_unittest.cc", 50 "trees/layer_tree_impl_unittest.cc",
51 "trees/occlusion_tracker_unittest.cc", 51 "trees/occlusion_tracker_unittest.cc",
52 "trees/occlusion_unittest.cc", 52 "trees/occlusion_unittest.cc",
53 diff --git a/cc/layers/video_frame_provider.h b/cc/layers/video_frame_provider.h 53 diff --git a/cc/layers/video_frame_provider.h b/cc/layers/video_frame_provider.h
54 deleted file mode 100644 54 deleted file mode 100644
55 index 784d951..0000000 55 index 784d951..0000000
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 - stream_texture_matrix_ = gfx::Transform( 234 - stream_texture_matrix_ = gfx::Transform(
235 - matrix[0], matrix[4], matrix[8], matrix[12], 235 - matrix[0], matrix[4], matrix[8], matrix[12],
236 - matrix[1], matrix[5], matrix[9], matrix[13], 236 - matrix[1], matrix[5], matrix[9], matrix[13],
237 - matrix[2], matrix[6], matrix[10], matrix[14], 237 - matrix[2], matrix[6], matrix[10], matrix[14],
238 - matrix[3], matrix[7], matrix[11], matrix[15]); 238 - matrix[3], matrix[7], matrix[11], matrix[15]);
239 - if (active_video_layer_) 239 - if (active_video_layer_)
240 - active_video_layer_->SetNeedsRedraw(); 240 - active_video_layer_->SetNeedsRedraw();
241 -} 241 -}
242 - 242 -
243 -} // namespace cc 243 -} // namespace cc
244 diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
245 index 613ea4b..3813e1d 100644
246 --- a/cc/output/gl_renderer.cc
247 +++ b/cc/output/gl_renderer.cc
248 @@ -18,7 +18,6 @@
249 #include "build/build_config.h"
250 #include "base/trace_event/trace_event.h"
251 #include "cc/base/math_util.h"
252 -#include "cc/layers/video_layer_impl.h"
253 #include "cc/output/compositor_frame.h"
254 #include "cc/output/compositor_frame_metadata.h"
255 #include "cc/output/context_provider.h"
256 diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc 244 diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc
257 index 295fc84..ebda8d6 100644 245 index d02df4f..9166ea8 100644
258 --- a/cc/output/renderer_pixeltest.cc 246 --- a/cc/output/renderer_pixeltest.cc
259 +++ b/cc/output/renderer_pixeltest.cc 247 +++ b/cc/output/renderer_pixeltest.cc
260 @@ -12,7 +12,6 @@ 248 @@ -11,7 +11,6 @@
261 #include "cc/test/fake_picture_pile_impl.h" 249 #include "cc/test/fake_picture_pile_impl.h"
262 #include "cc/test/pixel_test.h" 250 #include "cc/test/pixel_test.h"
263 #include "gpu/command_buffer/client/gles2_interface.h" 251 #include "gpu/command_buffer/client/gles2_interface.h"
264 -#include "media/base/video_frame.h" 252 -#include "media/base/video_frame.h"
265 #include "third_party/skia/include/core/SkColorPriv.h" 253 #include "third_party/skia/include/core/SkColorPriv.h"
266 #include "third_party/skia/include/core/SkImageFilter.h" 254 #include "third_party/skia/include/core/SkImageFilter.h"
267 #include "third_party/skia/include/core/SkMatrix.h" 255 #include "third_party/skia/include/core/SkMatrix.h"
268 @@ -902,243 +901,6 @@ TEST_F(GLRendererPixelTest, NonPremultipliedTextureWithBac kground) { 256 @@ -907,267 +906,6 @@ TEST_F(GLRendererPixelTest, NonPremultipliedTextureWithBac kground) {
269 FuzzyPixelOffByOneComparator(true))); 257 FuzzyPixelOffByOneComparator(true)));
270 } 258 }
271 259
272 -class VideoGLRendererPixelTest : public GLRendererPixelTest { 260 -class VideoGLRendererPixelTest : public GLRendererPixelTest {
273 - protected: 261 - protected:
274 - void CreateEdgeBleedPass(media::VideoFrame::Format format, 262 - void CreateEdgeBleedPass(media::VideoFrame::Format format,
275 - RenderPassList* pass_list) { 263 - RenderPassList* pass_list) {
276 - gfx::Rect rect(200, 200); 264 - gfx::Rect rect(200, 200);
277 - 265 -
278 - RenderPassId id(1, 1); 266 - RenderPassId id(1, 1);
(...skipping 14 matching lines...) Expand all
293 - static_cast<float>(green_rect.y()) / background_size.height(), 281 - static_cast<float>(green_rect.y()) / background_size.height(),
294 - static_cast<float>(green_rect.width()) / background_size.width(), 282 - static_cast<float>(green_rect.width()) / background_size.width(),
295 - static_cast<float>(green_rect.height()) / background_size.height()); 283 - static_cast<float>(green_rect.height()) / background_size.height());
296 - 284 -
297 - // YUV of (149,43,21) should be green (0,255,0) in RGB. 285 - // YUV of (149,43,21) should be green (0,255,0) in RGB.
298 - // Create a video frame that has a non-green background rect, with a 286 - // Create a video frame that has a non-green background rect, with a
299 - // green sub-rectangle that should be the only thing displayed in 287 - // green sub-rectangle that should be the only thing displayed in
300 - // the final image. Bleeding will appear on all four sides of the video 288 - // the final image. Bleeding will appear on all four sides of the video
301 - // if the tex coords are not clamped. 289 - // if the tex coords are not clamped.
302 - CreateTestYUVVideoDrawQuad_TwoColor( 290 - CreateTestYUVVideoDrawQuad_TwoColor(
303 - shared_state, format, false, tex_coord_rect, background_size, 0, 0, 0, 291 - shared_state, format, false, tex_coord_rect, background_size,
304 - green_rect, 149, 43, 21, pass.get(), video_resource_updater_.get(), 292 - gfx::Rect(background_size), 0, 0, 0, green_rect, 149, 43, 21,
305 - resource_provider_.get()); 293 - pass.get(), video_resource_updater_.get(), resource_provider_.get());
306 - pass_list->push_back(pass.Pass()); 294 - pass_list->push_back(pass.Pass());
307 - } 295 - }
308 - 296 -
309 - void SetUp() override { 297 - void SetUp() override {
310 - GLRendererPixelTest::SetUp(); 298 - GLRendererPixelTest::SetUp();
311 - video_resource_updater_.reset(new VideoResourceUpdater( 299 - video_resource_updater_.reset(new VideoResourceUpdater(
312 - output_surface_->context_provider(), resource_provider_.get())); 300 - output_surface_->context_provider(), resource_provider_.get()));
313 - } 301 - }
314 - 302 -
315 - scoped_ptr<VideoResourceUpdater> video_resource_updater_; 303 - scoped_ptr<VideoResourceUpdater> video_resource_updater_;
316 -}; 304 -};
317 - 305 -
318 -TEST_F(VideoGLRendererPixelTest, SimpleYUVRect) { 306 -TEST_F(VideoGLRendererPixelTest, SimpleYUVRect) {
319 - gfx::Rect rect(this->device_viewport_size_); 307 - gfx::Rect rect(this->device_viewport_size_);
320 - 308 -
321 - RenderPassId id(1, 1); 309 - RenderPassId id(1, 1);
322 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 310 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
323 - 311 -
324 - SharedQuadState* shared_state = 312 - SharedQuadState* shared_state =
325 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 313 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
326 - 314 -
327 - CreateTestYUVVideoDrawQuad_Striped(shared_state, media::VideoFrame::YV12, 315 - CreateTestYUVVideoDrawQuad_Striped(shared_state, media::VideoFrame::YV12,
328 - false, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 316 - false, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f),
329 - pass.get(), video_resource_updater_.get(), 317 - pass.get(), video_resource_updater_.get(),
330 - rect, resource_provider_.get()); 318 - rect, rect, resource_provider_.get());
331 - 319 -
332 - RenderPassList pass_list; 320 - RenderPassList pass_list;
333 - pass_list.push_back(pass.Pass()); 321 - pass_list.push_back(pass.Pass());
334 - 322 -
335 - EXPECT_TRUE( 323 - EXPECT_TRUE(
336 - this->RunPixelTest(&pass_list, 324 - this->RunPixelTest(&pass_list,
337 - base::FilePath(FILE_PATH_LITERAL("yuv_stripes.png")), 325 - base::FilePath(FILE_PATH_LITERAL("yuv_stripes.png")),
338 - FuzzyPixelOffByOneComparator(true))); 326 - FuzzyPixelOffByOneComparator(true)));
339 -} 327 -}
340 - 328 -
329 -TEST_F(VideoGLRendererPixelTest, ClippedYUVRect) {
330 - gfx::Rect viewport(this->device_viewport_size_);
331 - gfx::Rect draw_rect(this->device_viewport_size_.width() * 1.5,
332 - this->device_viewport_size_.height() * 1.5);
333 -
334 - RenderPassId id(1, 1);
335 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, viewport);
336 -
337 - SharedQuadState* shared_state =
338 - CreateTestSharedQuadState(gfx::Transform(), viewport, pass.get());
339 -
340 - CreateTestYUVVideoDrawQuad_Striped(shared_state, media::VideoFrame::YV12,
341 - false, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f),
342 - pass.get(), video_resource_updater_.get(),
343 - draw_rect, viewport,
344 - resource_provider_.get());
345 - RenderPassList pass_list;
346 - pass_list.push_back(pass.Pass());
347 -
348 - EXPECT_TRUE(this->RunPixelTest(
349 - &pass_list, base::FilePath(FILE_PATH_LITERAL("yuv_stripes_clipped.png")),
350 - FuzzyPixelOffByOneComparator(true)));
351 -}
352 -
341 -TEST_F(VideoGLRendererPixelTest, OffsetYUVRect) { 353 -TEST_F(VideoGLRendererPixelTest, OffsetYUVRect) {
342 - gfx::Rect rect(this->device_viewport_size_); 354 - gfx::Rect rect(this->device_viewport_size_);
343 - 355 -
344 - RenderPassId id(1, 1); 356 - RenderPassId id(1, 1);
345 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 357 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
346 - 358 -
347 - SharedQuadState* shared_state = 359 - SharedQuadState* shared_state =
348 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 360 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
349 - 361 -
350 - // Intentionally sets frame format to I420 for testing coverage. 362 - // Intentionally sets frame format to I420 for testing coverage.
351 - CreateTestYUVVideoDrawQuad_Striped( 363 - CreateTestYUVVideoDrawQuad_Striped(
352 - shared_state, media::VideoFrame::I420, false, 364 - shared_state, media::VideoFrame::I420, false,
353 - gfx::RectF(0.125f, 0.25f, 0.75f, 0.5f), pass.get(), 365 - gfx::RectF(0.125f, 0.25f, 0.75f, 0.5f), pass.get(),
354 - video_resource_updater_.get(), rect, resource_provider_.get()); 366 - video_resource_updater_.get(), rect, rect, resource_provider_.get());
355 - 367 -
356 - RenderPassList pass_list; 368 - RenderPassList pass_list;
357 - pass_list.push_back(pass.Pass()); 369 - pass_list.push_back(pass.Pass());
358 - 370 -
359 - EXPECT_TRUE(this->RunPixelTest( 371 - EXPECT_TRUE(this->RunPixelTest(
360 - &pass_list, 372 - &pass_list,
361 - base::FilePath(FILE_PATH_LITERAL("yuv_stripes_offset.png")), 373 - base::FilePath(FILE_PATH_LITERAL("yuv_stripes_offset.png")),
362 - FuzzyPixelOffByOneComparator(true))); 374 - FuzzyPixelOffByOneComparator(true)));
363 -} 375 -}
364 - 376 -
365 -TEST_F(VideoGLRendererPixelTest, SimpleYUVRectBlack) { 377 -TEST_F(VideoGLRendererPixelTest, SimpleYUVRectBlack) {
366 - gfx::Rect rect(this->device_viewport_size_); 378 - gfx::Rect rect(this->device_viewport_size_);
367 - 379 -
368 - RenderPassId id(1, 1); 380 - RenderPassId id(1, 1);
369 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 381 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
370 - 382 -
371 - SharedQuadState* shared_state = 383 - SharedQuadState* shared_state =
372 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 384 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
373 - 385 -
374 - // In MPEG color range YUV values of (15,128,128) should produce black. 386 - // In MPEG color range YUV values of (15,128,128) should produce black.
375 - CreateTestYUVVideoDrawQuad_Solid( 387 - CreateTestYUVVideoDrawQuad_Solid(
376 - shared_state, media::VideoFrame::YV12, false, 388 - shared_state, media::VideoFrame::YV12, false,
377 - gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 15, 128, 128, pass.get(), 389 - gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 15, 128, 128, pass.get(),
378 - video_resource_updater_.get(), rect, resource_provider_.get()); 390 - video_resource_updater_.get(), rect, rect, resource_provider_.get());
379 - 391 -
380 - RenderPassList pass_list; 392 - RenderPassList pass_list;
381 - pass_list.push_back(pass.Pass()); 393 - pass_list.push_back(pass.Pass());
382 - 394 -
383 - // If we didn't get black out of the YUV values above, then we probably have a 395 - // If we didn't get black out of the YUV values above, then we probably have a
384 - // color range issue. 396 - // color range issue.
385 - EXPECT_TRUE(this->RunPixelTest(&pass_list, 397 - EXPECT_TRUE(this->RunPixelTest(&pass_list,
386 - base::FilePath(FILE_PATH_LITERAL("black.png")) , 398 - base::FilePath(FILE_PATH_LITERAL("black.png")) ,
387 - FuzzyPixelOffByOneComparator(true))); 399 - FuzzyPixelOffByOneComparator(true)));
388 -} 400 -}
389 - 401 -
390 -TEST_F(VideoGLRendererPixelTest, SimpleYUVJRect) { 402 -TEST_F(VideoGLRendererPixelTest, SimpleYUVJRect) {
391 - gfx::Rect rect(this->device_viewport_size_); 403 - gfx::Rect rect(this->device_viewport_size_);
392 - 404 -
393 - RenderPassId id(1, 1); 405 - RenderPassId id(1, 1);
394 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 406 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
395 - 407 -
396 - SharedQuadState* shared_state = 408 - SharedQuadState* shared_state =
397 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 409 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
398 - 410 -
399 - // YUV of (149,43,21) should be green (0,255,0) in RGB. 411 - // YUV of (149,43,21) should be green (0,255,0) in RGB.
400 - CreateTestYUVVideoDrawQuad_Solid( 412 - CreateTestYUVVideoDrawQuad_Solid(
401 - shared_state, media::VideoFrame::YV12J, false, 413 - shared_state, media::VideoFrame::YV12J, false,
402 - gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 149, 43, 21, pass.get(), 414 - gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 149, 43, 21, pass.get(),
403 - video_resource_updater_.get(), rect, resource_provider_.get()); 415 - video_resource_updater_.get(), rect, rect, resource_provider_.get());
404 - 416 -
405 - RenderPassList pass_list; 417 - RenderPassList pass_list;
406 - pass_list.push_back(pass.Pass()); 418 - pass_list.push_back(pass.Pass());
407 - 419 -
408 - EXPECT_TRUE(this->RunPixelTest(&pass_list, 420 - EXPECT_TRUE(this->RunPixelTest(&pass_list,
409 - base::FilePath(FILE_PATH_LITERAL("green.png")) , 421 - base::FilePath(FILE_PATH_LITERAL("green.png")) ,
410 - FuzzyPixelOffByOneComparator(true))); 422 - FuzzyPixelOffByOneComparator(true)));
411 -} 423 -}
412 - 424 -
413 -// Test that a YUV video doesn't bleed outside of its tex coords when the 425 -// Test that a YUV video doesn't bleed outside of its tex coords when the
(...skipping 20 matching lines...) Expand all
434 - RenderPassId id(1, 1); 446 - RenderPassId id(1, 1);
435 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 447 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
436 - 448 -
437 - SharedQuadState* shared_state = 449 - SharedQuadState* shared_state =
438 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 450 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
439 - 451 -
440 - // Dark grey in JPEG color range (in MPEG, this is black). 452 - // Dark grey in JPEG color range (in MPEG, this is black).
441 - CreateTestYUVVideoDrawQuad_Solid( 453 - CreateTestYUVVideoDrawQuad_Solid(
442 - shared_state, media::VideoFrame::YV12J, false, 454 - shared_state, media::VideoFrame::YV12J, false,
443 - gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 15, 128, 128, pass.get(), 455 - gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 15, 128, 128, pass.get(),
444 - video_resource_updater_.get(), rect, resource_provider_.get()); 456 - video_resource_updater_.get(), rect, rect, resource_provider_.get());
445 - 457 -
446 - RenderPassList pass_list; 458 - RenderPassList pass_list;
447 - pass_list.push_back(pass.Pass()); 459 - pass_list.push_back(pass.Pass());
448 - 460 -
449 - EXPECT_TRUE( 461 - EXPECT_TRUE(
450 - this->RunPixelTest(&pass_list, 462 - this->RunPixelTest(&pass_list,
451 - base::FilePath(FILE_PATH_LITERAL("dark_grey.png")), 463 - base::FilePath(FILE_PATH_LITERAL("dark_grey.png")),
452 - FuzzyPixelOffByOneComparator(true))); 464 - FuzzyPixelOffByOneComparator(true)));
453 -} 465 -}
454 - 466 -
455 -TEST_F(VideoGLRendererPixelTest, SimpleYUVARect) { 467 -TEST_F(VideoGLRendererPixelTest, SimpleYUVARect) {
456 - gfx::Rect rect(this->device_viewport_size_); 468 - gfx::Rect rect(this->device_viewport_size_);
457 - 469 -
458 - RenderPassId id(1, 1); 470 - RenderPassId id(1, 1);
459 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 471 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
460 - 472 -
461 - SharedQuadState* shared_state = 473 - SharedQuadState* shared_state =
462 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 474 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
463 - 475 -
464 - CreateTestYUVVideoDrawQuad_Striped(shared_state, media::VideoFrame::YV12A, 476 - CreateTestYUVVideoDrawQuad_Striped(shared_state, media::VideoFrame::YV12A,
465 - false, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 477 - false, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f),
466 - pass.get(), video_resource_updater_.get(), 478 - pass.get(), video_resource_updater_.get(),
467 - rect, resource_provider_.get()); 479 - rect, rect, resource_provider_.get());
468 - 480 -
469 - SolidColorDrawQuad* color_quad = 481 - SolidColorDrawQuad* color_quad =
470 - pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 482 - pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
471 - color_quad->SetNew(shared_state, rect, rect, SK_ColorWHITE, false); 483 - color_quad->SetNew(shared_state, rect, rect, SK_ColorWHITE, false);
472 - 484 -
473 - RenderPassList pass_list; 485 - RenderPassList pass_list;
474 - pass_list.push_back(pass.Pass()); 486 - pass_list.push_back(pass.Pass());
475 - 487 -
476 - EXPECT_TRUE(this->RunPixelTest( 488 - EXPECT_TRUE(this->RunPixelTest(
477 - &pass_list, 489 - &pass_list,
478 - base::FilePath(FILE_PATH_LITERAL("yuv_stripes_alpha.png")), 490 - base::FilePath(FILE_PATH_LITERAL("yuv_stripes_alpha.png")),
479 - FuzzyPixelOffByOneComparator(true))); 491 - FuzzyPixelOffByOneComparator(true)));
480 -} 492 -}
481 - 493 -
482 -TEST_F(VideoGLRendererPixelTest, FullyTransparentYUVARect) { 494 -TEST_F(VideoGLRendererPixelTest, FullyTransparentYUVARect) {
483 - gfx::Rect rect(this->device_viewport_size_); 495 - gfx::Rect rect(this->device_viewport_size_);
484 - 496 -
485 - RenderPassId id(1, 1); 497 - RenderPassId id(1, 1);
486 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect); 498 - scoped_ptr<RenderPass> pass = CreateTestRootRenderPass(id, rect);
487 - 499 -
488 - SharedQuadState* shared_state = 500 - SharedQuadState* shared_state =
489 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get()); 501 - CreateTestSharedQuadState(gfx::Transform(), rect, pass.get());
490 - 502 -
491 - CreateTestYUVVideoDrawQuad_Striped(shared_state, media::VideoFrame::YV12A, 503 - CreateTestYUVVideoDrawQuad_Striped(shared_state, media::VideoFrame::YV12A,
492 - true, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f), 504 - true, gfx::RectF(0.0f, 0.0f, 1.0f, 1.0f),
493 - pass.get(), video_resource_updater_.get(), 505 - pass.get(), video_resource_updater_.get(),
494 - rect, resource_provider_.get()); 506 - rect, rect, resource_provider_.get());
495 - 507 -
496 - SolidColorDrawQuad* color_quad = 508 - SolidColorDrawQuad* color_quad =
497 - pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 509 - pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
498 - color_quad->SetNew(shared_state, rect, rect, SK_ColorBLACK, false); 510 - color_quad->SetNew(shared_state, rect, rect, SK_ColorBLACK, false);
499 - 511 -
500 - RenderPassList pass_list; 512 - RenderPassList pass_list;
501 - pass_list.push_back(pass.Pass()); 513 - pass_list.push_back(pass.Pass());
502 - 514 -
503 - EXPECT_TRUE(this->RunPixelTest( 515 - EXPECT_TRUE(this->RunPixelTest(
504 - &pass_list, 516 - &pass_list,
505 - base::FilePath(FILE_PATH_LITERAL("black.png")), 517 - base::FilePath(FILE_PATH_LITERAL("black.png")),
506 - ExactPixelComparator(true))); 518 - ExactPixelComparator(true)));
507 -} 519 -}
508 - 520 -
509 TYPED_TEST(RendererPixelTest, FastPassColorFilterAlpha) { 521 TYPED_TEST(RendererPixelTest, FastPassColorFilterAlpha) {
510 gfx::Rect viewport_rect(this->device_viewport_size_); 522 gfx::Rect viewport_rect(this->device_viewport_size_);
511 523
512 diff --git a/cc/quads/yuv_video_draw_quad.h b/cc/quads/yuv_video_draw_quad.h
513 index 358929e..15bce98 100644
514 --- a/cc/quads/yuv_video_draw_quad.h
515 +++ b/cc/quads/yuv_video_draw_quad.h
516 @@ -8,7 +8,6 @@
517 #include "base/basictypes.h"
518 #include "base/memory/scoped_ptr.h"
519 #include "cc/base/cc_export.h"
520 -#include "cc/layers/video_layer_impl.h"
521 #include "cc/quads/draw_quad.h"
522
523 namespace cc {
524 diff --git a/cc/resources/drawing_display_item.cc b/cc/resources/drawing_display _item.cc 524 diff --git a/cc/resources/drawing_display_item.cc b/cc/resources/drawing_display _item.cc
525 index 648f9de..6dffad9 100644 525 index 648f9de..6dffad9 100644
526 --- a/cc/resources/drawing_display_item.cc 526 --- a/cc/resources/drawing_display_item.cc
527 +++ b/cc/resources/drawing_display_item.cc 527 +++ b/cc/resources/drawing_display_item.cc
528 @@ -6,6 +6,7 @@ 528 @@ -6,6 +6,7 @@
529 529
530 #include <string> 530 #include <string>
531 531
532 +#include "base/logging.h" 532 +#include "base/logging.h"
533 #include "base/strings/stringprintf.h" 533 #include "base/strings/stringprintf.h"
534 #include "base/trace_event/trace_event_argument.h" 534 #include "base/trace_event/trace_event_argument.h"
535 #include "cc/debug/picture_debug_util.h" 535 #include "cc/debug/picture_debug_util.h"
536 diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_hos t_impl_unittest.cc 536 diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_hos t_impl_unittest.cc
537 index 4289a99..4e3230b 100644 537 index 8056387..e8471e2 100644
538 --- a/cc/trees/layer_tree_host_impl_unittest.cc 538 --- a/cc/trees/layer_tree_host_impl_unittest.cc
539 +++ b/cc/trees/layer_tree_host_impl_unittest.cc 539 +++ b/cc/trees/layer_tree_host_impl_unittest.cc
540 @@ -27,7 +27,6 @@ 540 @@ -26,7 +26,6 @@
541 #include "cc/layers/solid_color_scrollbar_layer_impl.h" 541 #include "cc/layers/solid_color_scrollbar_layer_impl.h"
542 #include "cc/layers/texture_layer_impl.h" 542 #include "cc/layers/texture_layer_impl.h"
543 #include "cc/layers/tiled_layer_impl.h" 543 #include "cc/layers/tiled_layer_impl.h"
544 -#include "cc/layers/video_layer_impl.h" 544 -#include "cc/layers/video_layer_impl.h"
545 #include "cc/output/begin_frame_args.h" 545 #include "cc/output/begin_frame_args.h"
546 #include "cc/output/compositor_frame_ack.h" 546 #include "cc/output/compositor_frame_ack.h"
547 #include "cc/output/compositor_frame_metadata.h" 547 #include "cc/output/compositor_frame_metadata.h"
548 @@ -47,7 +46,6 @@ 548 @@ -47,7 +46,6 @@
549 #include "cc/test/fake_picture_layer_impl.h" 549 #include "cc/test/fake_picture_layer_impl.h"
550 #include "cc/test/fake_picture_pile_impl.h" 550 #include "cc/test/fake_picture_pile_impl.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 - video_layer->SetBounds(gfx::Size(10, 10)); 607 - video_layer->SetBounds(gfx::Size(10, 10));
608 - video_layer->SetContentBounds(gfx::Size(10, 10)); 608 - video_layer->SetContentBounds(gfx::Size(10, 10));
609 - video_layer->SetDrawsContent(true); 609 - video_layer->SetDrawsContent(true);
610 - root_layer->AddChild(video_layer.Pass()); 610 - root_layer->AddChild(video_layer.Pass());
611 - SetupRootLayerImpl(root_layer.Pass()); 611 - SetupRootLayerImpl(root_layer.Pass());
612 - 612 -
613 LayerTreeHostImpl::FrameData frame; 613 LayerTreeHostImpl::FrameData frame;
614 EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); 614 EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
615 host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); 615 host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
616 diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_uni ttest.cc 616 diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_uni ttest.cc
617 index 68a1f58..2ec6e66 100644 617 index aacabd7..9416474 100644
618 --- a/cc/trees/layer_tree_host_unittest.cc 618 --- a/cc/trees/layer_tree_host_unittest.cc
619 +++ b/cc/trees/layer_tree_host_unittest.cc 619 +++ b/cc/trees/layer_tree_host_unittest.cc
620 @@ -18,7 +18,6 @@ 620 @@ -17,7 +17,6 @@
621 #include "cc/layers/painted_scrollbar_layer.h" 621 #include "cc/layers/painted_scrollbar_layer.h"
622 #include "cc/layers/picture_layer.h" 622 #include "cc/layers/picture_layer.h"
623 #include "cc/layers/solid_color_layer.h" 623 #include "cc/layers/solid_color_layer.h"
624 -#include "cc/layers/video_layer.h" 624 -#include "cc/layers/video_layer.h"
625 #include "cc/output/begin_frame_args.h" 625 #include "cc/output/begin_frame_args.h"
626 #include "cc/output/compositor_frame_ack.h" 626 #include "cc/output/compositor_frame_ack.h"
627 #include "cc/output/copy_output_request.h" 627 #include "cc/output/copy_output_request.h"
628 @@ -41,7 +40,6 @@ 628 @@ -41,7 +40,6 @@
629 #include "cc/test/fake_picture_pile.h" 629 #include "cc/test/fake_picture_pile.h"
630 #include "cc/test/fake_proxy.h" 630 #include "cc/test/fake_proxy.h"
631 #include "cc/test/fake_scoped_ui_resource.h" 631 #include "cc/test/fake_scoped_ui_resource.h"
632 -#include "cc/test/fake_video_frame_provider.h" 632 -#include "cc/test/fake_video_frame_provider.h"
633 #include "cc/test/geometry_test_utils.h" 633 #include "cc/test/geometry_test_utils.h"
634 #include "cc/test/impl_side_painting_settings.h" 634 #include "cc/test/impl_side_painting_settings.h"
635 #include "cc/test/layer_tree_test.h" 635 #include "cc/test/layer_tree_test.h"
636 @@ -4170,28 +4168,6 @@ class LayerInvalidateCausesDraw : public LayerTreeHostTes t { 636 @@ -4256,28 +4254,6 @@ class LayerInvalidateCausesDraw : public LayerTreeHostTes t {
637 int num_draws_; 637 int num_draws_;
638 }; 638 };
639 639
640 -// VideoLayer must support being invalidated and then passing that along 640 -// VideoLayer must support being invalidated and then passing that along
641 -// to the compositor thread, even though no resources are updated in 641 -// to the compositor thread, even though no resources are updated in
642 -// response to that invalidation. 642 -// response to that invalidation.
643 -class LayerTreeHostTestVideoLayerInvalidate : public LayerInvalidateCausesDraw { 643 -class LayerTreeHostTestVideoLayerInvalidate : public LayerInvalidateCausesDraw {
644 - public: 644 - public:
645 - void SetupTree() override { 645 - void SetupTree() override {
646 - LayerTreeHostTest::SetupTree(); 646 - LayerTreeHostTest::SetupTree();
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 - scoped_refptr<VideoFrame> color_video_frame_; 766 - scoped_refptr<VideoFrame> color_video_frame_;
767 - scoped_refptr<VideoFrame> hw_video_frame_; 767 - scoped_refptr<VideoFrame> hw_video_frame_;
768 - scoped_refptr<VideoFrame> scaled_hw_video_frame_; 768 - scoped_refptr<VideoFrame> scaled_hw_video_frame_;
769 - 769 -
770 - FakeVideoFrameProvider color_frame_provider_; 770 - FakeVideoFrameProvider color_frame_provider_;
771 - FakeVideoFrameProvider hw_frame_provider_; 771 - FakeVideoFrameProvider hw_frame_provider_;
772 - FakeVideoFrameProvider scaled_hw_frame_provider_; 772 - FakeVideoFrameProvider scaled_hw_frame_provider_;
773 }; 773 };
774 774
775 SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostContextTestDontUseLostResources); 775 SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostContextTestDontUseLostResources);
OLDNEW
« no previous file with comments | « gpu/perftests/texture_upload_perftest.cc ('k') | sandbox/linux/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698